Skip to content

Commit b31ef48

Browse files
authored
fix(tests): Add dedicated route for Hono query_string tests (getsentry#21731)
1 parent ce6f731 commit b31ef48

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

dev-packages/e2e-tests/test-applications/hono-4/src/route-groups/test-route-patterns.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ routePatterns.get('/async', async c => {
1515
return c.text('async response');
1616
});
1717

18+
// Dedicated route for query_string test to avoid transaction name collisions
19+
routePatterns.get('/query-test', c => c.text('query test response'));
20+
1821
// .all() registration
1922
routePatterns.all('/all', c => c.text('all handler response'));
2023

dev-packages/e2e-tests/test-applications/hono-4/tests/route-patterns.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,18 +95,18 @@ test.describe('request data extraction', () => {
9595
const transactionPromise = waitForTransaction(APP_NAME, event => {
9696
return (
9797
event.contexts?.trace?.op === 'http.server' &&
98-
event.transaction === `GET ${PREFIX}` &&
98+
event.transaction === `GET ${PREFIX}/query-test` &&
9999
event.request?.query_string === 'foo=bar&baz=42'
100100
);
101101
});
102102

103-
const response = await fetch(`${baseURL}${PREFIX}?foo=bar&baz=42`);
103+
const response = await fetch(`${baseURL}${PREFIX}/query-test?foo=bar&baz=42`);
104104
expect(response.status).toBe(200);
105105

106106
const transaction = await transactionPromise;
107107

108108
expect(transaction.request?.method).toBe('GET');
109-
expect(transaction.request?.url).toContain(PREFIX);
109+
expect(transaction.request?.url).toContain(`${PREFIX}/query-test`);
110110
expect(transaction.request?.query_string).toBe('foo=bar&baz=42');
111111
});
112112

0 commit comments

Comments
 (0)