[CHANGE] selecting a tab from overflow popup just inserts the selected tab at last visible index, this should behave more like the OS does.

Author: Michael Ehrmann

Source/PSMTabBarControl.m

@@ -1998,15 +1998,22 @@ - (void)tabView:(NSTabView *)aTabView didSelectTabViewItem:(NSTabViewItem *)tabV
 			id tempDelegate = [aTabView delegate];
 			[aTabView setDelegate:nil];
 
+			PSMTabBarCell *lastVisibleCell = self.lastVisibleTab;
+			NSUInteger *lastVisibleCellIndex = [self.cells indexOfObject:lastVisibleCell];
+
 			// move it all around first
 			[tabViewItem retain];
 			[thisCell retain];
+
 			[aTabView removeTabViewItem:tabViewItem];
-			[aTabView insertTabViewItem:tabViewItem atIndex:0];
+			[aTabView insertTabViewItem:tabViewItem atIndex:lastVisibleCellIndex];
+
             [self removeCellAtIndex:(NSUInteger)tabIndex];
-            [self insertCell:thisCell atIndex:0];
-			[thisCell setIsInOverflowMenu:NO];                  //very important else we get a fun recursive loop going
-			[[_cells objectAtIndex:[_cells count] - 1] setIsInOverflowMenu:YES];             //these 2 lines are pretty uncool and this logic needs to be updated
+            [self insertCell:thisCell atIndex:lastVisibleCellIndex];
+
+			[thisCell setIsInOverflowMenu:NO];                  // very important else we get a fun recursive loop going
+			[lastVisibleCell setIsInOverflowMenu:YES];			// now the former lastVisible Cell goes into the overflow popup
+
 			[thisCell release];
 			[tabViewItem release];