[FIX] make sure overflow button position is calculated from the current cell position. stabilizes position while live resizing window.

Michael Ehrmann · Michael Ehrmann · commit 005b97eb564e · 2014-03-14T17:16:47.000+01:00
diff --git a/Source/PSMTabBarControl.m b/Source/PSMTabBarControl.m
@@ -1272,7 +1272,6 @@ - (void)update:(BOOL)animate {
 	NSMenu *overflowMenu = [_controller overflowMenu];
 	[_overflowPopUpButton setHidden:(overflowMenu == nil)];
 	[_overflowPopUpButton setMenu:overflowMenu];
-    [self _positionOverflowMenu];        
 
 	if(_animationTimer) {
 		[_animationTimer invalidate];
@@ -1311,6 +1310,7 @@ - (void)update:(BOOL)animate {
         [self updateTrackingAreas];
 		[self setNeedsDisplay:YES];
 	}
+	[self _positionOverflowMenu];
 }
 
 - (void)_animateCells:(NSTimer *)timer {
@@ -1391,6 +1391,7 @@ - (void)_animateCells:(NSTimer *)timer {
         [self updateTrackingAreas];
 	}
 
+	[self _positionOverflowMenu];
 	[self setNeedsDisplay:YES];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1272,7 +1272,6 @@ - (void)update:(BOOL)animate {`
`1272`	`1272`	`NSMenu *overflowMenu = [_controller overflowMenu];`
`1273`	`1273`	`[_overflowPopUpButton setHidden:(overflowMenu == nil)];`
`1274`	`1274`	`[_overflowPopUpButton setMenu:overflowMenu];`
`1275`		`- [self _positionOverflowMenu];`
`1276`	`1275`
`1277`	`1276`	`if(_animationTimer) {`
`1278`	`1277`	`[_animationTimer invalidate];`
`@@ -1311,6 +1310,7 @@ - (void)update:(BOOL)animate {`
`1311`	`1310`	`[self updateTrackingAreas];`
`1312`	`1311`	`[self setNeedsDisplay:YES];`
`1313`	`1312`	`}`
	`1313`	`+ [self _positionOverflowMenu];`
`1314`	`1314`	`}`
`1315`	`1315`
`1316`	`1316`	`- (void)_animateCells:(NSTimer *)timer {`
`@@ -1391,6 +1391,7 @@ - (void)_animateCells:(NSTimer *)timer {`
`1391`	`1391`	`[self updateTrackingAreas];`
`1392`	`1392`	`}`
`1393`	`1393`
	`1394`	`+ [self _positionOverflowMenu];`
`1394`	`1395`	`[self setNeedsDisplay:YES];`
`1395`	`1396`	`}`
`1396`	`1397`