Pin django-dramatiq instead of dramatiq version #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.00% // Head: 91.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 16 16
Lines 700 700
=======================================
Hits 637 637
Misses 63 63 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@amureki can you update this? |
I believe, the core problem was in django_dramatiq package: Bogdanp/django_dramatiq#123 Version 0.11 is not fully uploaded to PyPI or there is a bug in that version. Also, there are no incompatibility issues raised in dramatiq repo: https://github.com/Bogdanp/dramatiq/issues Thus, I am changing pins in this PR to freeze django-dramatiq package.
amureki
force-pushed
the
django-dramatiq
branch
from
b5d833e to
36f4a61
Compare
done |
codingjoe
approved these changes
Oct 28, 2022
amureki
added a commit
that referenced
this pull request
Jan 2, 2023
Follow up to #58 Issues mentioned were fixed in the latest django-dramatiq version, 0.11.2. So it should work just fine now, we can unpin it.
amureki
added a commit
that referenced
this pull request
Jan 5, 2023
Follow up to #58 Issues mentioned were fixed in the latest django-dramatiq version, 0.11.2. So it should work just fine now, we can unpin it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe, the core problem was in django_dramatiq package:
Bogdanp/django_dramatiq#123
Version 0.11 is not fully uploaded to PyPI or there is a bug in that version.
Also, there are no incompatibility issues raised in dramatiq repo:
https://github.com/Bogdanp/dramatiq/issues
Thus, I am changing pins in this PR to freeze django-dramatiq package.
@codingjoe WDYT?