Zhenjieruan/modal stack #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as a general pattern
…ith a unique id for convenience of future updates of the content, then it's pushed to the stack. MODAL_DISMISS action will always pop the latest modal, but since modals are labeled, dismiss behavior can change in the future
…have multiple modals, and some other minor naming.
…uan/modal-stack # Conflicts: # app/components/Modal/actions.js
|
@ZhenjieRuan 抱歉这次我没注意，一些修改我直接推到你的分支了，下次我会建 PR 的。 |
KevenYoung
pushed a commit
that referenced
this pull request
Aug 17, 2018
Merge pull request #366 from chunqiuyiyu/yiyu/tencent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish coding/WebIDE#59 @hackape