Hackape/dnd tab on pane #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackape
commented
Nov 3, 2016
| @@ -0,0 +1,18 @@ | |||
| const promiseActionMixin = (actionCreator) => { | |||
There was a problem hiding this comment.
这是之前在 Modal/actions 里用就过的一个模式，就是给 action 补上 .then/.catch 方法，让它成为一个伪 promise，可以在任何需要的地方调用 action.meta.resolve/.reject 来出发 promise resolve/reject.
现在把它抽象出来放到 utils 里。
hackape
commented
Nov 3, 2016
| @@ -56,7 +56,9 @@ class AceEditor extends Component { | |||
| editor.setTheme(`ace/theme/${theme}`); | |||
| editor.$blockScrolling = Infinity; | |||
| // dispatch(EditorActions.registerEditor(this.state.name, editor, this.editorDOM)); | |||
| if (tab.content) { | |||
| if (tab.editor) { | |||
| editor.setSession(tab.editor.getSession()) | |||
There was a problem hiding this comment.
tab.editor 是一个 ace Editor 实例。tab 在转移 tabGroup 的时候会把 tab.editor 一起带着走，但我找不到简单的方法去替换这个 editor instance 对应的 DOM，所以退而求其次，把它的 editorSession 转移到新建的 editor instance 里，效果也一样。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
补全之前做了一半的拖拽分屏任务，现在 tab 能正确转移到对应的 tabGroup 中。
close coding/WebIDE#50