Added LCA and tests #88

nethish · 2020-01-30T07:50:58Z

Fixes #62
Added algorithms for Lowest common ancestors for binary search trees.
Added tests for LCA.

codecov · 2020-01-30T07:51:55Z

Codecov Report

Merging #88 into master will increase coverage by 0.436%.
The diff coverage is 95%.

@@              Coverage Diff              @@
##            master       #88       +/-   ##
=============================================
+ Coverage   97.385%   97.821%   +0.436%     
=============================================
  Files           30        20       -10     
  Lines         1721      1423      -298     
=============================================
- Hits          1676      1392      -284     
+ Misses          45        31       -14

Impacted Files	Coverage Δ
pydatastructs/trees/binary_trees.py	`96.651% <95%> (+0.214%)`	⬆️
...astructs/miscellaneous_data_structures/__init__.py	`100% <0%> (ø)`	⬆️
pydatastructs/graphs/__init__.py	`100% <0%> (ø)`	⬆️
pydatastructs/linear_data_structures/__init__.py	`100% <0%> (ø)`	⬆️
...datastructs/linear_data_structures/linked_lists.py	`100% <0%> (ø)`	⬆️
...tructs/trees/tests/test_space_partitioning_tree.py
pydatastructs/utils/tests/test_misc_util.py
...ydatastructs/graphs/tests/test_adjacency_matrix.py
pydatastructs/graphs/tests/test_adjacency_list.py
...neous_data_structures/tests/test_binomial_trees.py
... and 10 more

pydatastructs/trees/binary_trees.py

pydatastructs/trees/tests/test_binary_trees.py

czgdp1807 · 2020-01-31T15:40:12Z

Do not close this PR. Just push the updates in master branch using the remote of your fork. The PR will be updated automatically.

czgdp1807 · 2020-02-01T17:24:25Z

pydatastructs/trees/binary_trees.py

+                    curr_root = self.tree[curr_root].right
+                if curr_root == u or curr_root == v:
+                    return curr_root
+                u_left = self.comparator(self.tree[u].key, self.tree[curr_root].key)


Please split this into two lines. Doesn't look clean.

czgdp1807 · 2020-02-01T17:24:33Z

pydatastructs/trees/binary_trees.py

+            u, v = self.search(j), self.search(k)
+            if (u is None) or (v is None):
+                return None
+            u_left = self.comparator(self.tree[u].key, self.tree[curr_root].key)


czgdp1807 · 2020-02-01T17:24:41Z

pydatastructs/trees/binary_trees.py

+            if (u is None) or (v is None):
+                return None
+            u_left = self.comparator(self.tree[u].key, self.tree[curr_root].key)
+            v_left = self.comparator(self.tree[v].key, self.tree[curr_root].key)


czgdp1807 · 2020-02-01T17:24:47Z

pydatastructs/trees/binary_trees.py

+                if curr_root == u or curr_root == v:
+                    return curr_root
+                u_left = self.comparator(self.tree[u].key, self.tree[curr_root].key)
+                v_left = self.comparator(self.tree[v].key, self.tree[curr_root].key)


pydatastructs/trees/binary_trees.py

czgdp1807 · 2020-02-03T11:50:21Z

pydatastructs/trees/binary_trees.py

+        Parameter
+        =========
+
+        key:


key: Python object

This isn't addressed.

czgdp1807 · 2020-02-03T11:51:04Z

pydatastructs/trees/binary_trees.py

+        key:
+            node to be searched
+
+        path:


path: list
Though I don't think it is needed in the API.

czgdp1807 · 2020-02-03T11:52:17Z

pydatastructs/trees/binary_trees.py

+        if self._simple_path(key, self.tree[root].left, path) or \
+            self._simple_path(key, self.tree[root].right, path):
+            return True


Please convert this into iterative logic using pydatastructs.Stack as Python has a finite recursion limit irrespective of the size of heap memory.

Stack hasn't been implemented yet.

Yes. I made all the changes you have mentioned except this.
pydatastruct.stack is still abstract.

See, https://github.com/codezonediitj/pydatastructs/blob/master/pydatastructs/miscellaneous_data_structures/stack.py#L9
Stack can be used to remove recursion here.

I just now saw that.
Ill start making the changes

czgdp1807 · 2020-02-03T11:52:55Z

@nethish Are you participating through JMOC?

czgdp1807 · 2020-02-14T13:24:48Z

@nethish Would you still like to work on it? Thanks.

nethish · 2020-02-15T08:27:07Z

Yes.

czgdp1807 · 2020-02-24T17:01:32Z

@nethish Any news on this?

nethish · 2020-03-05T09:17:22Z

I have made all the changes.

czgdp1807 · 2020-03-05T10:01:17Z

pydatastructs/trees/binary_trees.py

+        Returns
+        =======
+
+        bool:


Suggested change

bool:

path[::-1]: bool

czgdp1807 · 2020-03-05T10:02:45Z

pydatastructs/trees/binary_trees.py

+
+            if curr_root is None:
+                return curr_root
+            return self.tree[curr_root].key


key may not always be an integer. So, this conflicts with the doc string.

czgdp1807 · 2020-03-05T10:09:28Z

pydatastructs/trees/binary_trees.py

+            curr_root = self.root_idx
+            u, v = self.search(j), self.search(k)
+            if (u is None) or (v is None):
+                return None


A value error would have been better to let the user know that they are searching for garbage values.

czgdp1807 · 2020-03-05T10:34:31Z

Will merge when the tests will pass.

Added LCA and tests

36de7f2

nethish requested a review from czgdp1807 January 30, 2020 07:53

czgdp1807 reviewed Jan 31, 2020

View reviewed changes

pydatastructs/trees/binary_trees.py Show resolved Hide resolved

czgdp1807 reviewed Jan 31, 2020

View reviewed changes

pydatastructs/trees/binary_trees.py Outdated Show resolved Hide resolved

czgdp1807 reviewed Jan 31, 2020

View reviewed changes

pydatastructs/trees/tests/test_binary_trees.py Outdated Show resolved Hide resolved

nethish added 4 commits February 1, 2020 00:00

Added tests for LCA and code correction

b894bce

Covered corner testcases

8dd5d23

Added docs for simple path

814daad

Added docs for simple path

f9099ba

czgdp1807 reviewed Feb 1, 2020

View reviewed changes

pydatastructs/trees/binary_trees.py Outdated Show resolved Hide resolved

czgdp1807 reviewed Feb 1, 2020

View reviewed changes

pydatastructs/trees/binary_trees.py Outdated Show resolved Hide resolved

nethish added 4 commits February 2, 2020 07:54

Merged simple_path functions

994e267

Merged simple_path functions and added docs

94817e0

Modified LCA to return key

a53d277

Removed extra statements

00ad7f7

czgdp1807 reviewed Feb 3, 2020

View reviewed changes

czgdp1807 added linear_data_structures trees and removed linear_data_structures labels Feb 4, 2020

nethish added 2 commits February 27, 2020 16:03

Implemented simple path using stack

f997c53

Implemented simple path using stack

3fa3760

czgdp1807 reviewed Mar 5, 2020

View reviewed changes

pydatastructs/trees/binary_trees.py Outdated

Returns

=======

bool:

Copy link

Member

czgdp1807 Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

bool:

path[::-1]: bool

czgdp1807 reviewed Mar 5, 2020

View reviewed changes

czgdp1807 added 2 commits March 5, 2020 15:51

final patch

e37ee7d

final tests

94d879c

czgdp1807 merged commit 0428473 into codezonediitj:master Mar 5, 2020

+                      Returns
+                      =======
+                      bool:

Added LCA and tests #88

Added LCA and tests #88

Uh oh!

Conversation

nethish commented Jan 30, 2020 • edited by czgdp1807 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

czgdp1807 commented Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

czgdp1807 commented Feb 3, 2020

Uh oh!

czgdp1807 commented Feb 14, 2020

Uh oh!

nethish commented Feb 15, 2020

Uh oh!

czgdp1807 commented Feb 24, 2020

Uh oh!

nethish commented Mar 5, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

czgdp1807 commented Mar 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nethish commented Jan 30, 2020 •

edited by czgdp1807

Loading

codecov bot commented Jan 30, 2020 •

edited

Loading

czgdp1807 commented Jan 31, 2020 •

edited

Loading