-
Notifications
You must be signed in to change notification settings - Fork 313
potential code refactor, optimize code performance #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
reviewed
Jan 19, 2021
czgdp1807
reviewed
Jan 19, 2021
czgdp1807
reviewed
Jan 19, 2021
czgdp1807
reviewed
Jan 19, 2021
czgdp1807
reviewed
Jan 19, 2021
czgdp1807
reviewed
Jan 19, 2021
Are you participating through any open source program? If yes then please let us know the name of the program so that appropriate label can be attached. |
Co-authored-by: Gagandeep Singh <gdp.1807@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=============================================
- Coverage 98.885% 98.828% -0.058%
=============================================
Files 25 25
Lines 3052 3072 +20
=============================================
+ Hits 3018 3036 +18
- Misses 34 36 +2
|
There are a bunch of |
czgdp1807
reviewed
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
Brief description of what is fixed or changed
This PR includes:
Remove unused imported modules [Anti-pattern]
Remove unnecessary
else
/elif
used afterreturn
orraise
return
statement causes the control flow to be disrupted, making theelse
/elif
block here unnecessary. This doesn't mean you can not use it, but it is recommended to refactor this for better readability.Remove unnecessary use of comprehension.
list
/set
/dict
out of it. Python has a specialized set of tools for this task: thelist
/set
/dict
constructors, which are faster and more readable.Changing the default arguments.
Remove
dict()
and use{}
Use tuple instead of multiple conditions, simplifying if expression.
Other comments