TileSlicer refactoring and decrease memory consumption

Author: unknown

res/layout/main.xml

@@ -1,9 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
-<merge xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_width="fill_parent"
-    android:layout_height="fill_parent">
-	<cz.destil.sliderpuzzle.GameboardView android:id="@+id/gameboard"
-	    android:layout_width="match_parent"
-	    android:layout_height="match_parent">
-	</cz.destil.sliderpuzzle.GameboardView>
-</merge>
+<cz.destil.sliderpuzzle.GameboardView xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/gameboard"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
+    android:background="@color/background" >
+
+</cz.destil.sliderpuzzle.GameboardView>

res/values/colors.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+
+    <color name="background">#585858</color>
+    <color name="tile_border">#fbfdff</color>
+
+</resources>

res/values/strings.xml

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
 
-    <string name="hello">Hello World, SliderPuzzleActivity!</string>
-    <string name="app_name">SliderPuzzle</string>
+    <string name="app_name">Slider Puzzle</string>
 
 </resources>

src/cz/destil/sliderpuzzle/GameboardView.java

@@ -22,20 +22,21 @@
 
 public class GameboardView extends RelativeLayout implements OnTouchListener {
 
+	public static final int GRID_SIZE = 4; //4x4
 	protected Size tileSize;
 	protected RectF gameboardRect;
 	protected HashSet<GameTile> tiles;
 	protected GameTile emptyTile, movedTile;
 	private boolean boardCreated;
 	private PointF lastDragPoint;
-	private TileServer tileServer;
+	private TileSlicer tileSlicer;
 	protected ArrayList<GameTileMotionDescriptor> currentMotionDescriptors;
 
 	public GameboardView(Context context, AttributeSet attrSet) {
 		super(context, attrSet);
 		Drawable globe = getResources().getDrawable(R.drawable.globe);
 		Bitmap original = ((BitmapDrawable)globe).getBitmap();
-		tileServer = new TileServer(original, 4, 4, 68);
+		tileSlicer = new TileSlicer(original, GRID_SIZE);
 
 		createTiles();
 	}
@@ -62,13 +63,13 @@ protected void placeTile(GameTile tile) {
 		params.topMargin = tileRect.top;
 		params.leftMargin = tileRect.left;
 		addView(tile, params);
-		tile.setImageBitmap(tileServer.serveRandomSlice());
+		tile.setImageBitmap(tileSlicer.getRandomSlice());
 	}
 
 	protected void createTiles() {
 		tiles = new HashSet<GameTile>();
-		for (int rowI=0; rowI<4; rowI++) {
-			for (int colI=0; colI<4; colI++) {
+		for (int rowI=0; rowI<GRID_SIZE; rowI++) {
+			for (int colI=0; colI<GRID_SIZE; colI++) {
 				GameTile tile = createTileAtCoordinate( new Coordinate(rowI, colI) );
 				if (rowI == 3 && colI == 3) {
 					emptyTile = tile;
@@ -362,13 +363,13 @@ protected void determineGameboardSizes() {
 		int viewHeight = getHeight();
 		int tileWidth = 0; 
 		if (viewWidth > viewHeight) {
-			tileWidth = viewHeight/4;
+			tileWidth = viewHeight/GRID_SIZE;
 		} else {
-			tileWidth = viewWidth/4;
+			tileWidth = viewWidth/GRID_SIZE;
 		}
 		tileSize = new Size(tileWidth, tileWidth);
-		int gameboardWidth = tileSize.width * 4;
-		int gameboardHeight = tileSize.height * 4;
+		int gameboardWidth = tileSize.width * GRID_SIZE;
+		int gameboardHeight = tileSize.height * GRID_SIZE;
 		int gameboardTop = viewHeight/2 - gameboardHeight/2;
 		int gameboardLeft = viewWidth/2 - gameboardWidth/2;
 		gameboardRect = new RectF(gameboardLeft, gameboardTop, gameboardLeft + gameboardWidth, gameboardTop + gameboardHeight);

src/cz/destil/sliderpuzzle/TileServer.java

@@ -0,0 +1,76 @@
+package cz.destil.sliderpuzzle;
+
+import java.util.ArrayList;
+import java.util.Random;
+
+import android.graphics.Bitmap;
+
+/**
+ * 
+ * Slices original bitmap into tiles and adds border. Provides randomized access
+ * to tiles.
+ * 
+ * Based on
+ * https://github.com/thillerson/Android-Slider-Puzzle/blob/master/src/com
+ * /tackmobile/TileServer.java
+ * 
+ * @author David Vavra
+ */
+public class TileSlicer {
+
+	private static final String TAG = "TileSlicer";
+	private Bitmap original;
+	private int tileSize;
+	private ArrayList<Bitmap> slices;
+	private Random random;
+
+	/**
+	 * Initializes TileSlicer.
+	 * 
+	 * @param original
+	 *            Bitmap which should be sliced
+	 * @param gridSize
+	 *            Grid size, for example 4 for 4x4 grid
+	 */
+	public TileSlicer(Bitmap original, int gridSize) {
+		super();
+		this.original = original;
+		this.tileSize = original.getWidth() / gridSize;
+		random = new Random();
+		slices = new ArrayList<Bitmap>();
+		sliceOriginal();
+	}
+
+	/**
+	 * Slices original bitmap and adds border to slices.
+	 */
+	private void sliceOriginal() {
+		int x, y;
+		Bitmap bitmap;
+		for (int rowI = 0; rowI < 4; rowI++) {
+			for (int colI = 0; colI < 4; colI++) {
+				x = rowI * tileSize;
+				y = colI * tileSize;
+				bitmap = Bitmap.createBitmap(original, x, y, tileSize, tileSize);
+				slices.add(bitmap);
+			}
+		}
+		// remove original bitmap from memory
+		original = null;
+	}
+
+	/**
+	 * Serves random slice and frees it from memory
+	 * 
+	 * @return Bitmap of random slice
+	 */
+	public Bitmap getRandomSlice() {
+		if (slices.size() > 0) {
+			int randomIndex = random.nextInt(slices.size());
+			Bitmap drawable = slices.remove(randomIndex);
+			return drawable;
+		}
+		return null;
+	}
+
+}