fix(onchange): support data-mutation-free on attributes change #2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested review from
TatianaFomina,
gohabereg and
ilyamore88
as code owners
gohabereg
approved these changes
Jun 22, 2023
ilyamore88
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now,
data-mutation-freeworks only onaddedNodesandremovedNodesof a mutation record. This PR also adds a support for "attributes" mutation type — we need to check recordtargetas well.For example, Table tool fires unnecessary
onChangecallings (See editor-js/table#125) when hovering on a table cells. That is fixed by adding adata-mutation-freeattribute. But that fix requires this PR to be merged