Bugfix/fix modification observer disable (#1340)

* Enable modification observer when onChange callback throws an error

* Build

* Update src/components/modules/modificationsObserver.ts

Co-authored-by: George Berezhnoy <gohabereg@users.noreply.github.com>

* Update CHANGELOG

Co-authored-by: t.hata <hata@impact-blue.co.jp>
Co-authored-by: George Berezhnoy <gohabereg@users.noreply.github.com>

Author: 3 people

dist/editor.js

@@ -21,6 +21,7 @@
 - `Fix` - blocks.getBlockByIndex() API method now returns void for indexes out of range [#1270](https://github.com/codex-team/editor.js/issues/1270)
 - `Fix` - Fixed the `onChange` callback issue. This method didn't be called for native inputs before some contentedtable element changed [#843](https://github.com/codex-team/editor.js/issues/843)
 - `Fix` - Fixed the `Tab` key behavior when the caret is not set inside contenteditable element, but the block is selected [#1302](https://github.com/codex-team/editor.js/issues/1302).
+- `Fix` - Fixed the `onChange` callback issue. This method didn't be called after the callback throws an exception [#1339](https://github.com/codex-team/editor.js/issues/1339)
 
 ### 2.18
 

docs/CHANGELOG.md

@@ -28,7 +28,7 @@ export default class ModificationsObserver extends Module {
   /**
    * Allows to temporary disable mutations handling
    */
-  private disabled: boolean;
+  private disabled = false;
 
   /**
    * Used to prevent several mutation callback execution
@@ -37,7 +37,10 @@ export default class ModificationsObserver extends Module {
    */
   private mutationDebouncer = _.debounce(() => {
     this.updateNativeInputs();
-    this.config.onChange(this.Editor.API.methods);
+
+    if (typeof this.config.onChange === 'function') {
+      this.config.onChange(this.Editor.API.methods);
+    }
   }, ModificationsObserver.DebounceTimer);
 
   /**
@@ -127,7 +130,7 @@ export default class ModificationsObserver extends Module {
    * @param {MutationRecord[]} mutationList - list of mutations
    * @param {MutationObserver} observer - observer instance
    */
-  private mutationHandler(mutationList: MutationRecord[], observer): void {
+  private mutationHandler(mutationList: MutationRecord[], observer: MutationObserver): void {
     /**
      * Skip mutations in stealth mode
      */

src/components/modules/modificationsObserver.ts

@@ -36,16 +36,18 @@ export default class Saver extends Module {
      */
     ModificationsObserver.disable();
 
-    blocks.forEach((block: Block) => {
-      chainData.push(this.getSavedData(block));
-    });
-
-    const extractedData = await Promise.all(chainData);
-    const sanitizedData = await Sanitizer.sanitizeBlocks(extractedData);
+    try {
+      blocks.forEach((block: Block) => {
+        chainData.push(this.getSavedData(block));
+      });
 
-    ModificationsObserver.enable();
+      const extractedData = await Promise.all(chainData);
+      const sanitizedData = await Sanitizer.sanitizeBlocks(extractedData);
 
-    return this.makeOutput(sanitizedData);
+      return this.makeOutput(sanitizedData);
+    } finally {
+      ModificationsObserver.enable();
+    }
   }
 
   /**