handling memory error in timeout utility #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed the use of `test.expect_no_error` inside the timeout utility: - done "manually", allowing to handle data passed to the thread - consequence: DOCS need an update because there isn't any extra assertion anymore, now. * tested on cw with 3.6, 3.8 wihtout imports, 3.8 with imports: work as expected. * removed a comment in the framework about the timeout (deprecated info) * added the default message for timeout ssertion (codewars#4) Still need to upddate the tests output (and maybe the tests files)
Blind4Basics
changed the title
adding extra checks about the timeout utility: * failing inner assertion * user's assertion message * user's code raising an error
|
@kazk: the tests are fucking slow to run... I bet this PR will still have troubles about the expected outputs, but if you can already take a look...? I'll try again to offer the possibility to wrap blocks with the timetout utility while avoiding the assertion outside any |
|
I don't get it... :/ exception isn't raised, apparently, while it's there in the test file. The memory crash is even weirder, because the exact same code is behaving as expected in a kumite... :/ Bed time, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the use of
test.expect_no_errorinside the timeout utility:tested on cw with 3.6, 3.8 wihtout imports, 3.8 with imports: work as expected.
removed a comment in the framework about the timeout (deprecated info)
added the default message for timeout ssertion (Supply custom error message on timeout tests #4)
Still need to upddate the tests output (and maybe the tests files)done => trying to pass the outputs checks... XD