From c3091576b3c089b8023adfcaa8631ac26ad540f8 Mon Sep 17 00:00:00 2001 From: schneems Date: Sat, 28 Oct 2023 10:37:31 -0500 Subject: [PATCH] Switch from rubocop to standardrb --- .github/workflows/main.yml | 9 +- .rubocop.yml | 170 ------------- .rubocop_todo.yml | 506 ------------------------------------- .standard.yml | 1 + Gemfile | 4 +- Gemfile.lock | 50 ++-- Rakefile | 2 +- app.json | 10 +- 8 files changed, 51 insertions(+), 701 deletions(-) delete mode 100644 .rubocop.yml delete mode 100644 .rubocop_todo.yml create mode 100644 .standard.yml diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1ed2fbf4d..7feec5be2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,7 +7,7 @@ jobs: strategy: fail-fast: false matrix: - ruby: ["3.0", 3.1] + ruby: ["3.1"] name: Running tests with Ruby ${{ matrix.ruby }} services: postgres: @@ -30,10 +30,15 @@ jobs: ruby-version: ${{ matrix.ruby }} bundler-cache: true + - name: Linting + run: | + bundle exec standardrb - name: Setup database run: | cp config/database.ci.yml config/database.yml RAILS_ENV=test bundle exec rake db:create db:schema:load - - name: Run tests run: bin/rake test + - name: Run seed tasks + run: rails db:seed + diff --git a/.rubocop.yml b/.rubocop.yml deleted file mode 100644 index 006a79309..000000000 --- a/.rubocop.yml +++ /dev/null @@ -1,170 +0,0 @@ -require: rubocop-performance - -AllCops: - DisabledByDefault: true - TargetRubyVersion: 3.1.2 - DisplayCopNames: true - StyleGuideCopsOnly: false - Exclude: - - 'tmp/**/*' - - 'db/schema.rb' - - 'vendor/**/*' - - 'perf_scripts/**/*' - - 'scratch.rb' - -Layout/ArrayAlignment: - Enabled: true - -Layout/HashAlignment: - Enabled: true - -Layout/ParameterAlignment: - Enabled: true - -Layout/BlockEndNewline: - Enabled: true - -Layout/ClosingParenthesisIndentation: - Enabled: true - -Layout/DotPosition: - Enabled: true - -Layout/ElseAlignment: - Enabled: true - -Layout/EmptyLineBetweenDefs: - Enabled: true - -Layout/EmptyLines: - Enabled: true - -Layout/EmptyLinesAroundAccessModifier: - Enabled: true - -Layout/EmptyLinesAroundBlockBody: - Enabled: true - -Layout/EmptyLinesAroundClassBody: - Enabled: true - -Layout/ExtraSpacing: - Enabled: true - -Layout/FirstArrayElementIndentation: - Enabled: true - -Layout/FirstHashElementIndentation: - Enabled: true - -Layout/IndentationConsistency: - Enabled: true - -Layout/IndentationWidth: - Enabled: true - -Layout/LeadingCommentSpace: - Enabled: true - -Layout/MultilineBlockLayout: - Enabled: true - -Layout/MultilineHashBraceLayout: - Enabled: true - -Layout/MultilineMethodCallBraceLayout: - Enabled: true - -Layout/MultilineMethodCallIndentation: - Enabled: true - -Layout/SpaceAfterComma: - Enabled: true - -Layout/SpaceAroundEqualsInParameterDefault: - Enabled: true - -Layout/SpaceAroundOperators: - Enabled: true - -Layout/SpaceBeforeBlockBraces: - Enabled: true - -Layout/SpaceBeforeComma: - Enabled: true - -Layout/SpaceBeforeFirstArg: - Enabled: true - -Layout/SpaceInLambdaLiteral: - Enabled: true - -Layout/SpaceInsideBlockBraces: - Enabled: true - -Layout/SpaceInsideArrayLiteralBrackets: - Enabled: true - AutoCorrect: true - -Layout/SpaceInsideReferenceBrackets: - Enabled: true - AutoCorrect: true - -Layout/SpaceInsideHashLiteralBraces: - Enabled: true - -Layout/SpaceInsideParens: - Enabled: true - -Layout/SpaceInsideStringInterpolation: - Enabled: true - -Layout/TrailingEmptyLines: - Enabled: true - -Layout/TrailingWhitespace: - Enabled: true - -Layout/EndAlignment: - Enabled: true - -Lint/AssignmentInCondition: - Enabled: true - -Lint/ScriptPermission: - Enabled: true - -Lint/UnusedBlockArgument: - Enabled: true - -Lint/UnusedMethodArgument: - Enabled: true - -Lint/UselessAssignment: - Enabled: true - -# Disable cause we always try to use Rails with last version and master -Bundler/DuplicatedGem: - Enabled: false - -Bundler/OrderedGems: - Enabled: false - -Performance/RedundantBlockCall: - Enabled: true - -Performance/RedundantMatch: - Enabled: true - -Performance/StringReplacement: - Enabled: true - -Performance/TimesMap: - Enabled: true - -Style/FrozenStringLiteralComment: - Enabled: true - Exclude: - - 'bin/*' - - 'db/*' - - 'db/migrate/*.rb' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index ed56ff08d..000000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,506 +0,0 @@ -inherit_from: "./.rubocop.yml" -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2017-08-09 09:34:22 +0200 using RuboCop version 0.49.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 20 -Metrics/AbcSize: - Max: 47 - -# Offense count: 6 -# Configuration parameters: CountComments, ExcludedMethods. -Metrics/BlockLength: - Max: 175 - -# Offense count: 3 -# Configuration parameters: CountComments. -Metrics/ClassLength: - Max: 180 - -# Offense count: 1 -Metrics/CyclomaticComplexity: - Max: 7 - -# Offense count: 329 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 214 - -# Offense count: 19 -# Configuration parameters: CountComments. -Metrics/MethodLength: - Max: 51 - -# Offense count: 1 -Metrics/PerceivedComplexity: - Max: 8 - -# Offense count: 9 -# Cop supports --auto-correct. -Rails/ApplicationRecord: - Exclude: - - 'app/models/doc_assignment.rb' - - 'app/models/doc_class.rb' - - 'app/models/doc_comment.rb' - - 'app/models/doc_method.rb' - - 'app/models/issue.rb' - - 'app/models/issue_assignment.rb' - - 'app/models/repo.rb' - - 'app/models/repo_subscription.rb' - - 'app/models/user.rb' - -# Offense count: 2 -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: strict, flexible -Rails/Date: - Exclude: - - 'lib/tasks/schedule.rake' - -# Offense count: 1 -# Cop supports --auto-correct. -Rails/Delegate: - Exclude: - - 'app/models/github_fetcher/resource.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: Whitelist. -# Whitelist: find_by_sql -Rails/DynamicFindBy: - Exclude: - - 'app/controllers/repo_based_controller.rb' - -# Offense count: 1 -Rails/FilePath: - Exclude: - - 'config/environments/development.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/FindBy: - Exclude: - - 'app/models/doc_mailer_maker.rb' - -# Offense count: 3 -# Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb -Rails/Output: - Exclude: - - 'config/puma.rb' - - 'lib/docs_doctor/task.rb' - -# Offense count: 3 -Rails/OutputSafety: - Exclude: - - 'app/controllers/users/omniauth_callbacks_controller.rb' - - 'app/helpers/application_helper.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. -Rails/Present: - Exclude: - - 'app/mailers/user_mailer.rb' - - 'app/models/user.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/ReadWriteAttribute: - Exclude: - - 'app/models/doc_method.rb' - -# Offense count: 6 -# Configuration parameters: Include. -# Include: db/migrate/*.rb -Rails/ReversibleMigration: - Exclude: - - 'db/migrate/20140710164307_remove_user_id_from_issue_assignments.rb' - - 'db/migrate/20150629002651_remove_repo_name_from_repo_subscriptions.rb' - - 'db/migrate/20150629010617_remove_user_name_from_repo_subscriptions.rb' - - 'db/migrate/20151214120117_enable_pg_stat_extension.rb' - - 'db/migrate/20160404173429_remove_user_from_doc_assignments.rb' - - 'db/migrate/20170801021151_default_value_for_max_issues.rb' - -# Offense count: 4 -# Configuration parameters: Blacklist. -# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters -Rails/SkipsModelValidations: - Exclude: - - 'app/jobs/send_daily_triage_email_job.rb' - - 'app/models/user.rb' - - 'db/migrate/20121106072214_repo_issue_counter_cache.rb' - -# Offense count: 11 -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: strict, flexible -Rails/TimeZone: - Exclude: - - 'app/controllers/doc_methods_controller.rb' - - 'app/controllers/issue_assignments_controller.rb' - - 'app/jobs/send_daily_triage_email_job.rb' - - 'app/models/doc_mailer_maker.rb' - - 'app/models/issue.rb' - - 'app/models/user.rb' - - 'db/seeds.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/Validation: - Exclude: - - 'app/models/user.rb' - -# Offense count: 1 -Style/AccessorMethodName: - Exclude: - - 'app/mailers/user_mailer.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: percent_q, bare_percent -Style/BarePercentLiterals: - Exclude: - - 'app/helpers/application_helper.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods. -# SupportedStyles: line_count_based, semantic, braces_for_chaining -# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object -# FunctionalMethods: let, let!, subject, watch -# IgnoredMethods: lambda, proc, it -Style/BlockDelimiters: - Exclude: - - 'test/functional/repos_controller_test.rb' - - 'test/unit/repo_test.rb' - -# Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: braces, no_braces, context_dependent -Style/BracesAroundHashParameters: - Exclude: - - 'db/migrate/20140621155109_add_delievered_to_issue_assignment.rb' - - 'test/integration/repos_test.rb' - - 'test/integration/user_update_test.rb' - - 'test/test_helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/CharacterLiteral: - Exclude: - - 'app/models/repo.rb' - -# Offense count: 13 -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: nested, compact -Style/ClassAndModuleChildren: - Exclude: - - 'app/controllers/users/after_signup_controller.rb' - - 'app/controllers/users/omniauth_callbacks_controller.rb' - - 'test/functional/omniauth_callbacks_controller_test.rb' - - 'test/test_helper.rb' - - 'test/unit/github_fetcher/commit_sha_test.rb' - - 'test/unit/github_fetcher/email_test.rb' - - 'test/unit/github_fetcher/issue_comments_test.rb' - - 'test/unit/github_fetcher/issue_test.rb' - - 'test/unit/github_fetcher/issues_test.rb' - - 'test/unit/github_fetcher/repo_test.rb' - - 'test/unit/github_fetcher/repos_test.rb' - - 'test/unit/github_fetcher/user_test.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: Keywords. -# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW -Style/CommentAnnotation: - Exclude: - - 'app/models/github_fetcher/repo.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly, IncludeTernaryExpressions. -# SupportedStyles: assign_to_condition, assign_inside_condition -Style/ConditionalAssignment: - Exclude: - - 'app/models/repo_subscription.rb' - -# Offense count: 111 -Style/Documentation: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/EmptyLiteral: - Exclude: - - 'test/unit/sorted_repo_collection_test.rb' - -# Offense count: 1 -# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms. -# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS -Style/FileName: - Exclude: - - 'config/initializers/mini-profiler.rb' - -# Offense count: 6 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Exclude: - - 'app/controllers/repos_controller.rb' - - 'app/controllers/users_controller.rb' - - 'app/models/repo.rb' - -# Offense count: 14 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. -# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys -Style/HashSyntax: - Exclude: - - 'config/environments/production.rb' - - 'config/routes.rb' - - 'db/migrate/20170629151616_add_unique_index_to_repos.rb' - - 'db/seeds.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: MaxLineLength. -Style/IfUnlessModifier: - Exclude: - - 'app/controllers/application_controller.rb' - - 'config/routes.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: line_count_dependent, lambda, literal -Style/Lambda: - Exclude: - - 'config/routes.rb' - - 'test/unit/github_fetcher/issue_comments_test.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/MultilineIfModifier: - Exclude: - - 'app/controllers/users/omniauth_callbacks_controller.rb' - - 'test/teaspoon_env.rb' - -# Offense count: 11 -# Cop supports --auto-correct. -Style/MutableConstant: - Exclude: - - 'app/models/email_rate_limit.rb' - - 'app/models/github_fetcher/repos.rb' - - 'app/models/issue.rb' - - 'app/models/repo.rb' - - 'config/initializers/git_hub_bub.rb' - - 'lib/docs_doctor/parsers/ruby/yard.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: both, prefix, postfix -Style/NegatedIf: - Exclude: - - 'app/models/doc_mailer_maker.rb' - - 'app/models/email_rate_limit.rb' - -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles. -# SupportedOctalStyles: zero_with_o, zero_only -Style/NumericLiteralPrefix: - Exclude: - - 'app/helpers/users_helper.rb' - - 'app/jobs/send_daily_triage_email_job.rb' - - 'test/jobs/send_daily_triage_email_job_test.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: Strict. -Style/NumericLiterals: - MinDigits: 15 - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: PreferredDelimiters. -Style/PercentLiteralDelimiters: - Exclude: - - 'app/helpers/application_helper.rb' - - 'config/spring.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/PerlBackrefs: - Exclude: - - 'app/controllers/repos_controller.rb' - -# Offense count: 1 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. -# NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? -Style/PredicateName: - Exclude: - - 'spec/**/*' - - 'app/models/user.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/Proc: - Exclude: - - 'app/models/doc_mailer_maker.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: SupportedStyles. -# SupportedStyles: compact, exploded -Style/RaiseArgs: - EnforcedStyle: compact - -# Offense count: 1 -# Cop supports --auto-correct. -Style/RedundantBegin: - Exclude: - - 'app/models/github_fetcher/user.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Exclude: - - 'app/models/doc_method.rb' - - 'app/models/github_fetcher/repo.rb' - - 'lib/docs_doctor/loader.rb' - - 'lib/docs_doctor/parsers/ruby/yard.rb' - -# Offense count: 25 -# Cop supports --auto-correct. -Style/RedundantSelf: - Exclude: - - 'app/models/issue.rb' - - 'app/models/repo.rb' - - 'app/models/repo_subscription.rb' - - 'app/models/user.rb' - - 'lib/docs_doctor/loader.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. -# SupportedStyles: slashes, percent_r, mixed -Style/RegexpLiteral: - Exclude: - - 'app/controllers/repos_controller.rb' - - 'app/models/doc_method.rb' - - 'config/routes.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Exclude: - - 'test/jobs/populate_issues_job_test.rb' - -# Offense count: 14 -# Cop supports --auto-correct. -# Configuration parameters: AllowIfMethodIsEmpty. -Style/SingleLineMethods: - Exclude: - - 'test/jobs/send_daily_triage_email_job_test.rb' - -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: SupportedStyles. -# SupportedStyles: use_perl_names, use_english_names -Style/SpecialGlobalVars: - EnforcedStyle: use_perl_names - -# Offense count: 863 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. -# SupportedStyles: single_quotes, double_quotes -Style/StringLiterals: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: single_quotes, double_quotes -Style/StringLiteralsInInterpolation: - Exclude: - - 'app/mailers/user_mailer.rb' - - 'config/environments/development.rb' - -# Offense count: 9 -# Cop supports --auto-correct. -# Configuration parameters: MinSize, SupportedStyles. -# SupportedStyles: percent, brackets -Style/SymbolArray: - EnforcedStyle: brackets - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: IgnoredMethods. -# IgnoredMethods: respond_to, define_method -Style/SymbolProc: - Exclude: - - 'app/models/user.rb' - -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStylesForMultiline. -# SupportedStylesForMultiline: comma, consistent_comma, no_comma -Style/TrailingCommaInArguments: - Exclude: - - 'app/models/github_fetcher/repo.rb' - - 'app/models/github_fetcher/repos.rb' - - 'app/models/issue.rb' - - 'test/integration/repos_test.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStylesForMultiline. -# SupportedStylesForMultiline: comma, consistent_comma, no_comma -Style/TrailingCommaInLiteral: - Exclude: - - 'test/unit/github_fetcher/issue_comments_test.rb' - - 'test/unit/github_fetcher/repos_test.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/UnneededPercentQ: - Exclude: - - 'app/helpers/application_helper.rb' - -# Offense count: 1 -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: snake_case, camelCase -Style/VariableName: - Exclude: - - 'app/controllers/pages_controller.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: MaxLineLength. -Style/WhileUntilModifier: - Exclude: - - 'app/jobs/populate_issues_job.rb' - -# Offense count: 13 -# Cop supports --auto-correct. -# Configuration parameters: SupportedStyles, WordRegex. -# SupportedStyles: percent, brackets -Style/WordArray: - EnforcedStyle: percent - MinSize: 7 diff --git a/.standard.yml b/.standard.yml new file mode 100644 index 000000000..72b2693c7 --- /dev/null +++ b/.standard.yml @@ -0,0 +1 @@ +ruby_version: 3.1 diff --git a/Gemfile b/Gemfile index 14344ada1..81bcd2fa1 100644 --- a/Gemfile +++ b/Gemfile @@ -7,7 +7,7 @@ git_source(:github) do |repo_name| "https://github.com/#{repo_name}.git" end -ruby ">= 2.7.2", "< 3.2" +ruby ">= 3.1", "< 3.3" git_source :github do |name| "https://github.com/#{name}.git" @@ -133,6 +133,6 @@ group :development, :test do gem 'dotenv-rails' gem 'faker', require: false gem 'pry' - gem 'rubocop', require: false + gem 'standardrb', require: false gem 'rubocop-performance' end diff --git a/Gemfile.lock b/Gemfile.lock index e9c495cbc..e8be9ce98 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -91,6 +91,7 @@ GEM babel-transpiler (0.7.0) babel-source (>= 4.0, < 6) execjs (~> 2.0) + base64 (0.1.1) bcrypt (3.1.19) benchmark-ips (2.9.1) bindex (0.8.1) @@ -178,14 +179,16 @@ GEM rails-dom-testing (>= 1, < 3) railties (>= 4.2.0) thor (>= 0.14, < 2.0) - json (2.6.2) + json (2.6.3) jwt (2.7.1) kramdown (2.4.0) rexml kramdown-parser-gfm (1.1.0) kramdown (~> 2.0) + language_server-protocol (3.17.0.3) launchy (2.5.0) addressable (~> 2.7) + lint_roller (1.1.0) listen (3.7.0) rb-fsevent (~> 0.10, >= 0.10.3) rb-inotify (~> 0.9, >= 0.9.10) @@ -258,9 +261,10 @@ GEM omniauth (~> 2.0) optimist (3.0.1) orm_adapter (0.5.0) - parallel (1.22.1) - parser (3.1.2.1) + parallel (1.23.0) + parser (3.2.2.4) ast (~> 2.4.1) + racc pdf-core (0.9.0) pg (1.2.3) prawn (2.4.0) @@ -342,29 +346,31 @@ GEM optimist (>= 3.0.0) redis-client (0.18.0) connection_pool - regexp_parser (2.6.0) + regexp_parser (2.8.2) render_async (2.1.11) responders (3.1.1) actionpack (>= 5.2) railties (>= 5.2) - rexml (3.2.5) + rexml (3.2.6) rrrretry (1.0.0) - rubocop (1.36.0) + rubocop (1.56.4) + base64 (~> 0.1.1) json (~> 2.3) + language_server-protocol (>= 3.17.0) parallel (~> 1.10) - parser (>= 3.1.2.1) + parser (>= 3.2.2.3) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.20.1, < 2.0) + rubocop-ast (>= 1.28.1, < 2.0) ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.21.0) - parser (>= 3.1.1.0) - rubocop-performance (1.15.0) + unicode-display_width (>= 2.4.0, < 3.0) + rubocop-ast (1.30.0) + parser (>= 3.2.1.0) + rubocop-performance (1.19.1) rubocop (>= 1.7.0, < 2.0) rubocop-ast (>= 0.4.0) - ruby-progressbar (1.11.0) + ruby-progressbar (1.13.0) ruby-statistics (2.1.3) ruby2_keywords (0.0.5) sass (3.7.4) @@ -424,6 +430,20 @@ GEM activesupport (>= 5.2) sprockets (>= 3.0.0) stackprof (0.2.17) + standard (1.31.2) + language_server-protocol (~> 3.17.0.2) + lint_roller (~> 1.0) + rubocop (~> 1.56.4) + standard-custom (~> 1.0.0) + standard-performance (~> 1.2) + standard-custom (1.0.2) + lint_roller (~> 1.0) + rubocop (~> 1.50) + standard-performance (1.2.1) + lint_roller (~> 1.1) + rubocop-performance (~> 1.19.1) + standardrb (1.0.1) + standard temple (0.8.2) test-prof (1.0.10) thor (1.3.0) @@ -437,7 +457,7 @@ GEM unf (0.1.4) unf_ext unf_ext (0.0.7.7) - unicode-display_width (2.3.0) + unicode-display_width (2.5.0) valid_email (0.1.4) activemodel mail (>= 2.6.1) @@ -521,7 +541,6 @@ DEPENDENCIES rbtrace render_async rrrretry - rubocop rubocop-performance sassc sassc-rails @@ -536,6 +555,7 @@ DEPENDENCIES sprockets sprockets-rails stackprof + standardrb test-prof uglifier (>= 1.0.3) valid_email diff --git a/Rakefile b/Rakefile index 4d7b91ff0..652a6a9e5 100644 --- a/Rakefile +++ b/Rakefile @@ -102,7 +102,7 @@ namespace :test do end end -task default: [:rubocop, :test] +task default: [:test] Rake::Task["assets:precompile"].enhance do Rake::Task["db:migrate"].invoke diff --git a/app.json b/app.json index 3fda8cab9..7b37a4013 100644 --- a/app.json +++ b/app.json @@ -1,13 +1,13 @@ { - "name":"Code Triage ", + "name": "Code Triage ", "description": "Helping you contribute to open source since 2013", "website": "https://www.codetriage.com/", "repository": "https://github.com/codetriage/codetriage", - "scripts":{ - "postdeploy":"rake db:schema:load db:migrate db:seed", - "test": "bundle exec rubocop && bin/rails test && rails db:seed" + "scripts": { + "postdeploy": "rake db:schema:load db:migrate db:seed", + "test": "bundle exec standardrb && bin/rails test && rails db:seed" }, - "env":{ + "env": { "DEVISE_SECRET_KEY": "foo", "DEVISE_SECRET_TOKEN": "bar", "WEB_CONCURRENCY": "1"