Skip to content

support --ignore-words-case-sensitive option. #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support --ignore-words-case-sensitive option. #3658

wants to merge 1 commit into from

Conversation

fujitatomoya
Copy link

closes #3638

fujitatomoya
fujitatomoya commented Mar 2, 2025
View reviewed changes
Copy link
Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitriPapadopoulos what do you think about this?

  • this PR keeps the current default behavior so no downstream packages are affected.
  • fix the documentation aligned with current implementation in default.
  • add --ignore-words-case-sensitive option, to ignore all words in a case-sensitive manner. this give more flexibility for user.

@fujitatomoya fujitatomoya mentioned this pull request Mar 2, 2025
Open
@fujitatomoya
Copy link
Author

@larsoner @peternewman could you guide me to proceed this PR?

@fujitatomoya fujitatomoya mentioned this pull request Mar 3, 2025
Open
@fujitatomoya
Copy link
Author

@DimitriPapadopoulos friendly ping 🙇

@fujitatomoya fujitatomoya mentioned this pull request Mar 10, 2025
Merged
@fujitatomoya
Copy link
Author

Hi maintainers, is there anything i can do on my side, nobody is responding at all... trying to get some attention here.

@fujitatomoya
Copy link
Author

@DimitriPapadopoulos could you please guide me how to get review for this PR?

@fujitatomoya
Copy link
Author

@larsoner @peternewman @DimitriPapadopoulos friendly ping, please.

@fujitatomoya
support --ignore-words-case-sensitive option.
de9a5db 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the ignore-words-case-sensitive-option branch from 89240dc to de9a5db Compare May 16, 2025 05:47
@fujitatomoya
Copy link
Author

@DimitriPapadopoulos friendly ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@peternewman peternewman Awaiting requested review from peternewman peternewman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore words become case-insensitive if it is only lowercase.
1 participant
@fujitatomoya