Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set maxConcurrentStreams with http2 #66

Open
sebastienros opened this issue Oct 21, 2020 · 1 comment
Open

Add option to set maxConcurrentStreams with http2 #66

sebastienros opened this issue Oct 21, 2020 · 1 comment
Labels
feature-request

Comments

@sebastienros
Copy link

I couldn't find a way to change the value of maxConcurrentStreams when using http2, and it seems it uses the default of 1000 based on this line:

bombardier/vendor/golang.org/x/net/http2/transport.go

Line 483 in ba2c55f

maxConcurrentStreams: 1000, // "infinite", per spec. 1000 seems good enough.

Would it make sense to add such an option?
@codesenberg
Copy link
Owner

It seems like now there's an option for this in Transport: link
Feel free to send a PR, if you're interested in adding this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastienros @codesenberg