-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Chore/add discord help #6519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/add discord help #6519
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad82449:
|
|
Build for latest commit ad82449 is at https://pr6519.build.csb.dev/s/new. |
danilowoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 'codesandbox.help.discord', | ||
| 'Join our discord server', | ||
| 'https://discord.gg/5BpufEP7MH' | ||
| 'https://discord.gg/C6vfhW3H6e' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, any reason why the link has changed? I guess I also need to update on Sandpack documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danilowoz, the link was changed so that we can look at this particular invite link from Discord and determine how many people are coming in from the client dashboard.
| <Stack justify="center"> | ||
| {links.map(({ href, Icon }) => ( | ||
| <Link | ||
| css={css({ color: 'sideBar.border' })} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a key prop; it's not a big deal, but it will introduce a console.error
What kind of change does this PR introduce?