Skip to content

Conversation

@acekyd
Copy link
Contributor

@acekyd acekyd commented Mar 7, 2022

What kind of change does this PR introduce?

  • Add Discord link to the help menu.
  • Show support channels on workspace tabs across the dashboard

@acekyd acekyd requested review from CompuIves and danilowoz March 7, 2022 19:42
@acekyd acekyd self-assigned this Mar 7, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad82449:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Mar 7, 2022

Build for latest commit ad82449 is at https://pr6519.build.csb.dev/s/new.

Copy link
Contributor

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'codesandbox.help.discord',
'Join our discord server',
'https://discord.gg/5BpufEP7MH'
'https://discord.gg/C6vfhW3H6e'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, any reason why the link has changed? I guess I also need to update on Sandpack documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilowoz, the link was changed so that we can look at this particular invite link from Discord and determine how many people are coming in from the client dashboard.

<Stack justify="center">
{links.map(({ href, Icon }) => (
<Link
css={css({ color: 'sideBar.border' })}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a key prop; it's not a big deal, but it will introduce a console.error

@acekyd acekyd merged commit f74995e into master Mar 8, 2022
@acekyd acekyd deleted the chore/add-discord-help branch March 8, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants