Skip to content

Conversation

@smhutch
Copy link
Contributor

@smhutch smhutch commented Sep 1, 2021

What kind of change does this PR introduce?

Speeds up our pre-commit hook. Note we couldn't reach for the latest version of lint-staged because it requires Node 12+.

What is the current behavior?

We use lint-staged to check js/ts files before committing. Checking all changes runs quite efficiently, but it's a bit slow when trying to commit only some of your local changes.

CleanShot 2021-09-01 at 14 38 39@2x

What is the new behavior?

Same as before, but faster. Was 50+ seconds for a partially committed file. Now it's sub 10 seconds on my machine. 🚀

CleanShot 2021-09-01 at 14 42 00@2x

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Ran locally.

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20ebdee:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Sep 1, 2021

Build for latest commit 20ebdee is at https://pr6090.build.csb.dev/s/new.

@smhutch smhutch merged commit e4bc896 into master Sep 1, 2021
@smhutch smhutch deleted the bump-lint-staged branch September 1, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants