fix(dashboard beta): feature flag wrapper over the component instead of the route #6040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilowoz
changed the title
smhutch
approved these changes
Aug 13, 2021
| * feature-flag query takes a few ms to load, and meanwhile the Route | ||
| * redirect the page because the route hasn't been registered yet | ||
| */ | ||
| component={isFeatureFlagBeta ? BetaRepositoriesPage : () => null} |
Contributor
There was a problem hiding this comment.
Would something like this work to avoid the possibility of rendering a blank page?
Suggested change
| component={isFeatureFlagBeta ? BetaRepositoriesPage : () => null} | |
| component={isFeatureFlagBeta ? BetaRepositoriesPage : () => <Redirect to={dashboardUrls.home(activeTeam)} />} |
Contributor
Author
There was a problem hiding this comment.
This would end up with the same behavior as before because the Redirect would be rendered anyway. A final and right solution would need some kind of loading state, but I think it's over-engineered for this beta version in a scenario that we control who has access to this.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d622bd3:
|
Contributor
|
Build for latest commit d622bd3 is at https://pr6040.build.csb.dev/s/new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CSB-918