Reset isForkingSandbox on error #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close codesandbox#1803. I'm not sure what's the best way to reset some state on error with Cerebral though. Basically, I'd like to be able to always reset this state at the end of the `forkSandbox` sequence (https://github.com/codesandbox/codesandbox-client/blob/master/packages/app/src/app/store/sequences.js#L162) instead of doing this in every single action called by this sequence.
|
This is a good approach! I think a bit cleaner approach would be to use paths, like we do here: https://github.com/codesandbox/codesandbox-client/blob/master/packages/app/src/app/store/sequences.js#L492-L496. In that example in the action we import |
|
Hey @CompuIves, I've updated to paths. Let me know if this matches what you had in mind 🙂 |
|
Looks good! Thank you! |
This was referenced Mar 12, 2020
This was referenced Oct 19, 2020
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1803.
I'm not sure what's the best way to reset some state on error with Cerebral though.
Basically, I'd like to be able to always reset this state at the end of the
forkSandboxsequence (https://github.com/codesandbox/codesandbox-client/blob/master/packages/app/src/app/store/sequences.js#L162) instead of doing this in every single action called by this sequence.