Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monaco can crash after fork on Firefox #694

Closed
cswl opened this issue Apr 4, 2018 · 2 comments · May be fixed by sitedata/codesandbox-client#34, sitedata/codesandbox-client#35, CharaD7/codesandbox-client#13, vutting4221/codesandbox-client#11 or Matthelonianxl/codesandbox-client#46
Closed

Monaco can crash after fork on Firefox #694

cswl opened this issue Apr 4, 2018 · 2 comments · May be fixed by sitedata/codesandbox-client#34, sitedata/codesandbox-client#35, CharaD7/codesandbox-client#13, vutting4221/codesandbox-client#11 or Matthelonianxl/codesandbox-client#46

Comments

@cswl
Copy link

cswl commented Apr 4, 2018

I just used the vanilla template.. and Ctrl+A delete... then the editor stuck..

Browser: Firefox 59.0.2

https://i.imgur.com/o13xLgg.png
@CompuIves CompuIves changed the title Why you no do error handling. Monaco can crash after fork on Firefox Apr 4, 2018
@CompuIves
Copy link
Member

Hey! I did some debugging and I was able to reproduce the issue in Firefox. Sometimes when you do a fork we get a race condition which causes Monaco to crash. It's fixed with a refresh.

We should fix this one.

@CompuIves
Copy link
Member

This one has been fixed!

This was referenced Jan 20, 2021
Open
Open
@CharaD7 CharaD7 mentioned this issue Jan 20, 2021
Open
@vutting4221 vutting4221 mentioned this issue Jan 20, 2021
Open
@CompuIves CompuIves mentioned this issue Jan 20, 2021
Closed
@Matthelonianxl Matthelonianxl mentioned this issue Jan 21, 2021
Open
@uniibu uniibu mentioned this issue Jan 21, 2021
Open
@CompuIves CompuIves mentioned this issue Jan 21, 2021
Closed
@Matthelonianxl Matthelonianxl mentioned this issue Jan 21, 2021
Open
@vutting4221 vutting4221 mentioned this issue Jan 21, 2021
Open
@CompuIves CompuIves mentioned this issue Jan 21, 2021
Closed
This was referenced Jan 21, 2021
Open
Open
@CharaD7 CharaD7 mentioned this issue Jan 21, 2021
Open
@CompuIves CompuIves mentioned this issue Jan 21, 2021
Closed
@uniibu uniibu mentioned this issue Jan 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 sitedata/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 sitedata/codesandbox-client
[Snyk] Fix for 24 vulnerabilities CharaD7/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 vutting4221/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 Matthelonianxl/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 Devpodio/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 Matthelonianxl/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 vutting4221/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 baophucct/codesandbox-client
[Snyk] Security upgrade immer from 3.3.0 to 8.0.1 baophucct/codesandbox-client
2 participants
@CompuIves @cswl