Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions in same sandbox differently for different people #5913

Open
3 tasks done
CompuIves opened this issue Jun 21, 2021 · 1 comment
Open
3 tasks done

Versions in same sandbox differently for different people #5913

CompuIves opened this issue Jun 21, 2021 · 1 comment

Comments

@CompuIves
Copy link
Member

🐛 bug report

Preflight Checklist

  • I have read the [Contributing Guidelines][contributing] for this project.
  • I agree to follow the [Code of Conduct][code_of_conduct] that this project
    adheres to.
  • I have searched the issue tracker for an issue that matches the one I want
    to file, without success.

Description of the problem

When dependencies have a version as a tag (like next) we expect that everyone will resolve to the same version, but because we cache the result of resolving the absolute version for the tag, people have sometimes run in the issue that one browser resolves a different version than the other browser. We should probably remove that caching so that everyone will always resolve the same absolute version for a tag.

How has this issue affected you? What are you trying to accomplish?

I've heard reports where people were debugging for hours ("It works on my machine!"), and finally found out that they resolved different versions. That's very frustrating, so I'd say that we should fix this soon.

To Reproduce

  1. Open a sandbox with react@next, find the request that resolves next to an absolute version
  2. Make sure that we don't cache that, either by changing our service worker settings in webpack.prod.js, or by changing the server logic so that we send no-cache headers.
@andy-hook
Copy link

Hey @CompuIves

I think we just ran into a similar issue when using the latest tag. The latest version of our package is 0.1.0 (at time of writing) but when using latest we appear to be receiving outdated type defs / package code. Pinning works as expected.



Works: https://codesandbox.io/s/compassionate-thunder-0i38b?file=/src/App.tsx



Errors: https://codesandbox.io/s/amazing-surf-smzs4?file=/src/App.tsx









Could this be related to the issue described above?







There also seems to be a UI bug when using latest and hovering the entry, the select defaults to an incorrect value:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants