Skip to content

Commit e20b9c8

Browse files
authored
fix: csb ci sandboxes (#8633)
1 parent 0a188d2 commit e20b9c8

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

packages/sandpack-core/src/npm/merge-dependency.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,14 @@ import * as semver from 'semver';
44

55
const VERSIONED_MODULE_RE = /^.+\/\d+\.\d+\.\d+\/.+$/;
66

7+
function safeSemverGt(v1: string, v2: string): boolean {
8+
try {
9+
return semver.gt(v1, v2);
10+
} catch {
11+
return true;
12+
}
13+
}
14+
715
export interface ILambdaResponse {
816
contents: {
917
[path: string]: { content: string };
@@ -219,7 +227,7 @@ export function mergeDependencies(responses: ILambdaResponse[]) {
219227
} else if (response.dependencyDependencies[depDepName]) {
220228
const exDepDep = response.dependencyDependencies[depDepName];
221229
// Determine which version is newer, needed for some checks later.
222-
const [newerVersionDepDep, olderVersionDepDep] = semver.gt(
230+
const [newerVersionDepDep, olderVersionDepDep] = safeSemverGt(
223231
newDepDep.resolved,
224232
exDepDep.resolved
225233
)

0 commit comments

Comments
 (0)