Adding unit tests for jest native integration (#464)

* Report testing errors in console * Add todo * Adding tests for jest-lite * Test cleanup
codesandbox · Jan 30, 2018 · a6dc3d1 · a6dc3d1
1 parent edd8101
commit a6dc3d1
Show file tree

Hide file tree

Showing 6 changed files with 465 additions and 39 deletions.
diff --git a/package.json b/package.json
@@ -15,6 +15,7 @@
       "lerna run start --parallel --ignore app & lerna run start:dev_api --scope app --stream",
     "test": "lerna run test",
     "test:integrations": "lerna exec --scope app --stream -- yarn test:integrations",
+    "test:jest-lite": "lerna exec --scope app --stream -- yarn run test jest-lite --watch --coverage",
     "lint": "lerna run lint",
     "add-contributor": "all-contributors add",
     "generate": "all-contributors generate",

diff --git a/...ages/app/src/app/components/sandbox/CodeEditor/monaco/workers/fetch-dependency-typings.js b/...ages/app/src/app/components/sandbox/CodeEditor/monaco/workers/fetch-dependency-typings.js
@@ -169,15 +169,16 @@ function fetchFromMeta(dependency, version, fetchedPaths) {
   return doFetch(`${depUrl}/?meta`)
     .then(response => JSON.parse(response))
     .then(meta => {
-      const filterAndFlatten = files => files.reduce((paths, file) => {
-        if (file.type === 'directory') {
-          return paths.concat(filterAndFlatten(file.files));
-        }
-        if (/\.d\.ts$/.test(file.path)) {
-          paths.push(file.path);
-        }
-        return paths;
-      }, []);
+      const filterAndFlatten = files =>
+        files.reduce((paths, file) => {
+          if (file.type === 'directory') {
+            return paths.concat(filterAndFlatten(file.files));
+          }
+          if (/\.d\.ts$/.test(file.path)) {
+            paths.push(file.path);
+          }
+          return paths;
+        }, []);
 
       const dtsFiles = filterAndFlatten(meta.files);
 
@@ -187,11 +188,9 @@ function fetchFromMeta(dependency, version, fetchedPaths) {
 
       dtsFiles.forEach(file => {
         doFetch(`${depUrl}/${file}`)
-          .then(dtsFile => addLib(
-            `node_modules/${dependency}${file}`,
-            dtsFile,
-            fetchedPaths
-          ))
+          .then(dtsFile =>
+            addLib(`node_modules/${dependency}${file}`, dtsFile, fetchedPaths)
+          )
           .catch(() => {});
       });
     });
@@ -238,16 +237,18 @@ function fetchAndAddDependencies(dependencies) {
           fetchedPaths
         ).catch(() => {
           // not available in package.json, try checking meta for inline .d.ts files
-          fetchFromMeta(dep, getVersion(dependencies[dep]), fetchedPaths).catch(() => {
-            // Not available in package.json or inline from meta, try checking in @types/
-            fetchFromDefinitelyTyped(
-              dep,
-              dependencies[dep],
-              fetchedPaths
-            ).catch(() => {
-              // Do nothing if it still can't be fetched
-            });
-          });
+          fetchFromMeta(dep, getVersion(dependencies[dep]), fetchedPaths).catch(
+            () => {
+              // Not available in package.json or inline from meta, try checking in @types/
+              fetchFromDefinitelyTyped(
+                dep,
+                dependencies[dep],
+                fetchedPaths
+              ).catch(() => {
+                // Do nothing if it still can't be fetched
+              });
+            }
+          );
         });
 
         loadedTypings.push(dep);

diff --git a/packages/app/src/app/components/sandbox/Preview/DevTools/Console/index.js b/packages/app/src/app/components/sandbox/Preview/DevTools/Console/index.js
@@ -105,7 +105,7 @@ class Console extends React.Component<Props, State> {
             this.addMessage('warn', [undefined], 'return');
           }
         } else {
-          this.addMessage('error', [aggregatedResults]);
+          this.addMessage('log', [error]);
         }
         break;
       }

diff --git a/packages/app/src/sandbox/compile.js b/packages/app/src/sandbox/compile.js
@@ -208,8 +208,11 @@ async function compile({
         result: transformJSON(aggregatedResults),
       });
       // End - Testing
-    } catch (e) {
-      // Fail silently
+    } catch (error) {
+      dispatch({
+        type: 'test-result',
+        error: manager.testRunner.reportError(error),
+      });
     }
 
     debug(`Total time: ${Date.now() - startTime}ms`);

diff --git a/packages/app/src/sandbox/eval/tests/jest-lite.js b/packages/app/src/sandbox/eval/tests/jest-lite.js
@@ -88,12 +88,14 @@ export default class TestRunner {
     });
   }
 
+  /* istanbul ignore next */
   async transpileTests() {
     for (let t of this.tests) {
       await this.manager.transpileModules(t, true);
     }
   }
 
+  /* istanbul ignore next */
   async runTests() {
     await this.transpileTests();
     this.tests.forEach(t => {
@@ -157,22 +159,14 @@ export default class TestRunner {
         : '👻';
     summaryMessage = `Test Summary: ${summaryEmoji}\n\n`;
     summaryMessage += 'Test Suites: ';
-    if (aggregatedResults.failedTestSuites !== null) {
-      summaryMessage += `${aggregatedResults.failedTestSuites} failed, `;
-    }
-    if (aggregatedResults.passedTestSuites !== null) {
-      summaryMessage += `${aggregatedResults.passedTestSuites} passed, `;
-    }
+    summaryMessage += `${aggregatedResults.failedTestSuites} failed, `;
+    summaryMessage += `${aggregatedResults.passedTestSuites} passed, `;
     summaryMessage += `${aggregatedResults.totalTestSuites} total`;
     summaryMessage += '\n';
 
     summaryMessage += 'Tests: ';
-    if (aggregatedResults.failedTests !== null) {
-      summaryMessage += `${aggregatedResults.failedTests} failed, `;
-    }
-    if (aggregatedResults.passedTests !== null) {
-      summaryMessage += `${aggregatedResults.passedTests} passed, `;
-    }
+    summaryMessage += `${aggregatedResults.failedTests} failed, `;
+    summaryMessage += `${aggregatedResults.passedTests} passed, `;
     summaryMessage += `${aggregatedResults.totalTests} total`;
     summaryMessage += '\n';
 
@@ -186,6 +180,10 @@ export default class TestRunner {
     return aggregatedResults;
   }
 
+  reportError({ message = 'something went wrong' }) {
+    return `Test Summary: 😢\nError: ${message}`;
+  }
+
   resetResults() {
     this.aggregatedResults = this._makeEmptyAggregatedResults();
   }