Fix logger member not correct; (apache#2605)

Fix java doc problem

Co-authored-by: shoothzj <shooothzj@gmail.com>

Author: hezhangjian

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java

@@ -35,13 +35,21 @@
  * Provides a buffering layer in front of a FileChannel.
  */
 public class BufferedChannel extends BufferedReadChannel implements Closeable {
-    // The capacity of the write buffer.
+    /**
+     * The capacity of the write buffer.
+     */
     protected final int writeCapacity;
-    // The position of the file channel's write pointer.
+    /**
+     * The position of the file channel's write pointer.
+     */
     protected AtomicLong writeBufferStartPosition = new AtomicLong(0);
-    // The buffer used to write operations.
+    /**
+     * The buffer used to write operations.
+     */
     protected final ByteBuf writeBuffer;
-    // The absolute position of the next write operation.
+    /**
+     * The absolute position of the next write operation.
+     */
     protected volatile long position;
 
     /*
@@ -197,8 +205,11 @@ public synchronized void flush() throws IOException {
         writeBufferStartPosition.set(fileChannel.position());
     }
 
-    /*
+    /**
      * force a sync operation so that data is persisted to the disk.
+     * @param forceMetadata
+     * @return
+     * @throws IOException
      */
     public long forceWrite(boolean forceMetadata) throws IOException {
         // This is the point up to which we had flushed to the file system page cache

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForSingleEntryLog.java

@@ -44,7 +44,7 @@ class EntryLogManagerForSingleEntryLog extends EntryLogManagerBase {
     private volatile BufferedLogChannel activeLogChannel;
     private long logIdBeforeFlush = INVALID_LID;
     private final AtomicBoolean shouldCreateNewEntryLog = new AtomicBoolean(false);
-    private EntryLogger.RecentEntryLogsStatus recentlyCreatedEntryLogsStatus;
+    private final EntryLogger.RecentEntryLogsStatus recentlyCreatedEntryLogsStatus;
 
     EntryLogManagerForSingleEntryLog(ServerConfiguration conf, LedgerDirsManager ledgerDirsManager,
             EntryLoggerAllocator entryLoggerAllocator, List<EntryLogger.EntryLogListener> listeners,

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

@@ -814,7 +814,7 @@ private void validateEntry(long ledgerId, long entryId, long entryLogId, long po
     }
 
     public ByteBuf internalReadEntry(long ledgerId, long entryId, long location, boolean validateEntry)
-            throws IOException, Bookie.NoEntryException {
+            throws IOException {
         long entryLogId = logIdForOffset(location);
         long pos = posForOffset(location);
 

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.java

@@ -394,7 +394,7 @@ private int getNumUsedPages() {
         return pageCount.get();
     }
 
-        /**
+    /**
      * Get the ledger entry page for a given <i>pageEntry</i>.
      *
      * @param ledger

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DefaultBookieAddressResolver.java

@@ -59,7 +59,7 @@ public BookieSocketAddress resolve(BookieId bookieId) {
                 log.debug("Resolving dummy bookie Id {} using legacy bookie resolver", bookieId);
                 return BookieSocketAddress.resolveDummyBookieId(bookieId);
             }
-            log.info("Cannot resolve {}, bookie is unknown", bookieId, ex.toString());
+            log.info("Cannot resolve {}, bookie is unknown {}", bookieId, ex.toString());
             throw new BookieIdNotResolvedException(bookieId, ex);
         } catch (Exception ex) {
             if (ex instanceof InterruptedException) {

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java

@@ -437,7 +437,7 @@ private static void updateEnsembleInfo(
 
         updateLoop.run().whenComplete((result, ex) -> {
                 if (ex == null) {
-                    LOG.info("Updated ZK for ledgerId: ({}:{}) to point ledger fragments"
+                    LOG.info("Updated ZK to point ledger fragments"
                              + " from old bookies to new bookies: {}", oldBookie2NewBookie);
 
                     ensembleUpdatedCb.processResult(BKException.Code.OK, null, null);

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java

@@ -269,9 +269,9 @@ public RackawareEnsemblePlacementPolicyImpl initialize(ClientConfiguration conf,
                 }
             } catch (RuntimeException re) {
                 if (!conf.getEnforceMinNumRacksPerWriteQuorum()) {
-                    LOG.error("Failed to initialize DNS Resolver {}, used default subnet resolver : {}",
+                    LOG.error("Failed to initialize DNS Resolver {}, used default subnet resolver : {} {}",
                             dnsResolverName, re, re.getMessage());
-                    dnsResolver = new DefaultResolver(() -> this.getDefaultRack());
+                    dnsResolver = new DefaultResolver(this::getDefaultRack);
                 } else {
                     /*
                      * if minNumRacksPerWriteQuorum is enforced, then it

bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java

@@ -271,7 +271,7 @@ private CompletableFuture<Versioned<BookieServiceInfo>> readBookieServiceInfoAsy
                     bookieServiceInfoCache.put(bookieId, result);
                     promise.complete(result);
                 } catch (IOException ex) {
-                    log.error("Cannot update BookieInfo for {}", ex);
+                    log.error("Cannot update BookieInfo for ", ex);
                     promise.completeExceptionally(KeeperException.create(KeeperException.Code.get(rc), path)
                             .initCause(ex));
                     return;
@@ -289,7 +289,7 @@ private CompletableFuture<Versioned<BookieServiceInfo>> readBookieServiceInfoAsy
                             bookieServiceInfoCache.put(bookieId, result);
                             promise.complete(result);
                         } catch (IOException ex) {
-                            log.error("Cannot update BookieInfo for {}", ex);
+                            log.error("Cannot update BookieInfo for ", ex);
                             promise.completeExceptionally(KeeperException.create(KeeperException.Code.get(rc2), path2)
                                     .initCause(ex));
                             return;

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java

@@ -152,8 +152,8 @@ protected Queue<Runnable> newTaskQueue(int maxPendingTasks) {
                         try {
                             CpuAffinity.acquireCore();
                         } catch (Throwable t) {
-                            LOG.warn("Failed to acquire CPU core for thread {}", Thread.currentThread().getName(),
-                                    t.getMessage(), t);
+                            LOG.warn("Failed to acquire CPU core for thread {} {}",
+                                    Thread.currentThread().getName(), t.getMessage(), t);
                         }
                     });
                 }

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java

@@ -578,7 +578,7 @@ public void operationComplete(Future<Channel> future) throws Exception {
                         if (future.isSuccess()) {
                             LOG.error("TLS Handshake failed: Could not authenticate.");
                         } else {
-                            LOG.error("TLS Handshake failure: {} ", future.cause());
+                            LOG.error("TLS Handshake failure: ", future.cause());
                         }
                         BookkeeperProtocol.Response.Builder errResponse = BookkeeperProtocol.Response.newBuilder()
                                 .setHeader(r.getHeader()).setStatus(BookkeeperProtocol.StatusCode.EIO);