Skip to content

Commit 71d06a3

Browse files
author
Piotr Wolak
committed
Update
1 parent d469cc1 commit 71d06a3

File tree

4 files changed

+6
-11
lines changed

4 files changed

+6
-11
lines changed

src/main/kotlin/com/codersee/springcoroutines/controller/CompanyController.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,11 @@ class CompanyController(
7474
id = id,
7575
requestedCompany = companyRequest.toModel()
7676
)
77-
?.let { company ->
77+
.let { company ->
7878
company.toResponse(
7979
users = findCompanyUsers(company)
8080
)
8181
}
82-
?: throw ResponseStatusException(
83-
HttpStatus.INTERNAL_SERVER_ERROR,
84-
"Unexpected error during company update."
85-
)
8682

8783
private suspend fun findCompanyUsers(company: Company) =
8884
userService.findUsersByCompanyId(company.id!!)

src/main/kotlin/com/codersee/springcoroutines/controller/UserController.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@ class UserController(
5858
id = id,
5959
requestedUser = userRequest.toModel()
6060
)
61-
?.let(User::toResponse)
62-
?: throw ResponseStatusException(HttpStatus.INTERNAL_SERVER_ERROR, "Unexpected error during user update.")
61+
.toResponse()
6362
}
6463

6564
private fun UserRequest.toModel(): User =

src/main/kotlin/com/codersee/springcoroutines/service/CompanyService.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import com.codersee.springcoroutines.model.Company
44
import com.codersee.springcoroutines.repository.CompanyRepository
55
import kotlinx.coroutines.flow.Flow
66
import org.springframework.http.HttpStatus
7-
import org.springframework.stereotype.Component
7+
import org.springframework.stereotype.Service
88
import org.springframework.web.server.ResponseStatusException
99

10-
@Component
10+
@Service
1111
class CompanyService(
1212
private val companyRepository: CompanyRepository
1313
) {
@@ -33,7 +33,7 @@ class CompanyService(
3333
suspend fun findAllCompaniesByNameLike(name: String): Flow<Company> =
3434
companyRepository.findByNameContaining(name)
3535

36-
suspend fun updateCompany(id: Long, requestedCompany: Company): Company? {
36+
suspend fun updateCompany(id: Long, requestedCompany: Company): Company {
3737
val foundCompany = companyRepository.findById(id)
3838

3939
return if (foundCompany == null)

src/main/kotlin/com/codersee/springcoroutines/service/UserService.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class UserService(
3434
userRepository.deleteById(id)
3535
}
3636

37-
suspend fun updateUser(id: Long, requestedUser: User): User? {
37+
suspend fun updateUser(id: Long, requestedUser: User): User {
3838
val foundUser = userRepository.findById(id)
3939

4040
return if (foundUser == null)

0 commit comments

Comments
 (0)