-
Notifications
You must be signed in to change notification settings - Fork 87
Update README.md #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ziobron Could you also check :)?
@@ -27,7 +27,7 @@ ___ | |||
|
|||
## Zadanie 4 | |||
|
|||
Napisz klasę `Map`, która będzie posiadała `std::vector<Island&>` przechowujący wszystkie wyspy na mapie, oraz zmienną `Island* currentPosition_` określającą aktualną pozycję gracza na mapie. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be pointer or std::unqiue_ptr but I don't remember, need to check :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what you ment with the assignment. I ment that reference can't be a type in vector because it is not assignable. https://stackoverflow.com/questions/922360/why-cant-i-make-a-vector-of-references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good suggestion. I only wonder if Map should be an owner of all Islands? I don't know now how it's gonna be used, but it seems ok.
@@ -27,7 +27,7 @@ ___ | |||
|
|||
## Zadanie 4 | |||
|
|||
Napisz klasę `Map`, która będzie posiadała `std::vector<Island&>` przechowujący wszystkie wyspy na mapie, oraz zmienną `Island* currentPosition_` określającą aktualną pozycję gracza na mapie. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good suggestion. I only wonder if Map should be an owner of all Islands? I don't know now how it's gonna be used, but it seems ok.
Your PR was merged! |
…atoraPorownania Implemented comparison operator in Alcohol class
No description provided.