Skip to content

Update README.md #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Update README.md #89

merged 1 commit into from
Jul 3, 2021

Conversation

BarTes8
Copy link
Contributor

@BarTes8 BarTes8 commented Jun 17, 2021

No description provided.

Copy link
Collaborator

@nauka-programowania-MA nauka-programowania-MA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziobron Could you also check :)?

@@ -27,7 +27,7 @@ ___

## Zadanie 4

Napisz klasę `Map`, która będzie posiadała `std::vector<Island&>` przechowujący wszystkie wyspy na mapie, oraz zmienną `Island* currentPosition_` określającą aktualną pozycję gracza na mapie.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be pointer or std::unqiue_ptr but I don't remember, need to check :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you ment with the assignment. I ment that reference can't be a type in vector because it is not assignable. https://stackoverflow.com/questions/922360/why-cant-i-make-a-vector-of-references

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good suggestion. I only wonder if Map should be an owner of all Islands? I don't know now how it's gonna be used, but it seems ok.

@@ -27,7 +27,7 @@ ___

## Zadanie 4

Napisz klasę `Map`, która będzie posiadała `std::vector<Island&>` przechowujący wszystkie wyspy na mapie, oraz zmienną `Island* currentPosition_` określającą aktualną pozycję gracza na mapie.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good suggestion. I only wonder if Map should be an owner of all Islands? I don't know now how it's gonna be used, but it seems ok.

@ziobron ziobron merged commit 4163401 into master Jul 3, 2021
@ziobron ziobron deleted the BarTes8-patch-1 branch July 3, 2021 09:33
@ziobron
Copy link
Contributor

ziobron commented Jul 3, 2021

Your PR was merged!
🏅 2 XP granted. Thanks @BarTes8 for making course materials better!

BarTes8 added a commit to BarTes8/object-oriented-programming that referenced this pull request Sep 18, 2021
…atoraPorownania

Implemented comparison operator in Alcohol class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants