better error handling in cli

Author: coderookie1994

src/Microstack.CLI/Commands/SubCommands/Users.cs

@@ -52,7 +52,7 @@ public class Users : BaseCommand
             LongName = "download",
             ShortName = "d",
             ShowInHelpText = true,
-            ValueName = "<CONFIG FILENAME>"
+            ValueName = "CONFIG FILENAME"
             )]
         public string Download { get; set; }
 
@@ -85,42 +85,25 @@ protected override async Task<int> OnExecute(CommandLineApplication app)
 
             if (!string.IsNullOrWhiteSpace(UserId))
             {
-
-                using (var client = new HttpClient())
+                var (response, error) = await _userSettingsProvider.GetUserSettings(UserId);
+                if (error)
                 {
-                    client.BaseAddress = new Uri(settings);
-                    try
-                    {
-                        var response = await (await client.GetAsync($"/api/users/{UserId}")).Content.ReadAsStringAsync();
-                        var formattedJson = JsonConvert.SerializeObject(JsonConvert.DeserializeObject(response), Formatting.Indented);
-                        OuputToConsole(formattedJson);
-                        return 0;
-                    }
-                    catch (Exception ex)
-                    {
-                        OutputError($"Error occurred while connecting to api {ex.Message}");
-                        return 1;
-                    }
+                    OutputError(response);
+                    return 1;
                 }
+                OuputToConsole(response);
+                return 0;
             }
             if (All)
             {
-                using (var client = new HttpClient())
+                var (response, error) = await _userSettingsProvider.ListAllUsers();
+                if (error)
                 {
-                    client.BaseAddress = new Uri(settings);
-                    try
-                    {
-                        var response = await (await client.GetAsync($"/api/users")).Content.ReadAsStringAsync();
-                        var formattedJson = JsonConvert.SerializeObject(JsonConvert.DeserializeObject(response), Formatting.Indented);
-                        OuputToConsole(formattedJson);
-                        return 0;
-                    }
-                    catch (Exception ex)
-                    {
-                        OutputError($"Error occurred while connecting to api {ex.Message}");
-                        return 1;
-                    }
+                    OutputError(response);
+                    return 1;
                 }
+                OuputToConsole(response);
+                return 0;
             }
             if (!string.IsNullOrWhiteSpace(Download))
             {

src/Microstack.CLI/Properties/launchSettings.json

@@ -4,7 +4,8 @@
       "commandName": "Project",
       "executablePath": "C:\\github.com\\mstack\\microstack\\bin\\Debug\\netcoreapp3.1\\microstack.exe",
       //"commandLineArgs": "run -v -c .mstkc2.json -p quotewf"
-      "commandLineArgs": "users -u sharthak_ghosh -p"
+      //"commandLineArgs": "users -u sharthak_ghosh -p"
+      "commandLineArgs": " users -u coderookie1995"
     }
   }
 }

src/Microstack.Configuration/Abstractions/IUserSettingsProvider.cs

@@ -1,12 +1,15 @@
 using System;
 using System.Collections.Generic;
 using System.Text;
+using System.Threading.Tasks;
 
 namespace Microstack.Configuration.Abstractions
 {
     public interface IUserSettingsProvider
     {
         string GetSettings();
         void AddSetting(string url);
+        Task<(string Response, bool Error)> GetUserSettings(string userId);
+        Task<(string Response, bool Error)> ListAllUsers();
     }
 }

src/Microstack.Configuration/UserSettingsProvider.cs

@@ -1,8 +1,11 @@
 using Microstack.Configuration.Abstractions;
+using Newtonsoft.Json;
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Net.Http;
 using System.Text;
+using System.Threading.Tasks;
 
 namespace Microstack.Configuration
 {
@@ -22,5 +25,49 @@ public string GetSettings()
 
             return File.ReadAllText(dirPath);
         }
+
+        public async Task<(string Response, bool Error)> GetUserSettings(string userId)
+        {
+            using (var client = new HttpClient())
+            {
+                client.BaseAddress = new Uri(GetSettings());
+                try
+                {
+                    var response = await client.GetAsync($"/api/users/{userId}");
+                    if (response.IsSuccessStatusCode)
+                    {
+                        var formattedJson = JsonConvert.SerializeObject(JsonConvert.DeserializeObject(await response.Content.ReadAsStringAsync()), Formatting.Indented);
+                        return (formattedJson, false);
+                    }
+                    return (await response.Content.ReadAsStringAsync(), true);
+                }
+                catch (Exception ex)
+                {
+                    return ($"Error occurred while connecting to api {ex.Message}", true);
+                }
+            }
+        }
+
+        public async Task<(string Response, bool Error)> ListAllUsers()
+        {
+            using (var client = new HttpClient())
+            {
+                client.BaseAddress = new Uri(GetSettings());
+                try
+                {
+                    var response = await client.GetAsync($"/api/users");
+                    if (response.IsSuccessStatusCode)
+                    {
+                        var formattedJson = JsonConvert.SerializeObject(JsonConvert.DeserializeObject(await response.Content.ReadAsStringAsync()), Formatting.Indented);
+                        return (formattedJson, false);
+                    }
+                    return (await response.Content.ReadAsStringAsync(), true);
+                }
+                catch (Exception ex)
+                {
+                    return ($"Error occurred while connecting to api {ex.Message}", true);
+                }
+            }
+        }
     }
 }