Switched publish command to a more commander-compliant syntax

Author: begedin

lib/cli/publish.js

@@ -3,42 +3,28 @@
 var program = require('commander');
 
 var dasherize = require('../utils/string').dasherize;
-var Promise = require('../ext/promise');
 var ui = require('../ui');
 
-function validateOptions(options) {
-  return new Promise(function(resolve, reject) {
-    if (!options.addonName) {
-      reject('You must provide a name of the addon you wish to publish');
-    } else if (!options.username) {
-      reject('A GitHub username is required');
-    } else if (!options.password) {
-      reject('A GitHub password is required');
-    } else {
-      resolve(options);
-    }
-  });
-}
-
-function run(options) {
-  return require('../tasks/publish')(options);
-}
-
 program
   .arguments('<addonName>')
-  .action(function(addonName) {
-    program.addonName = addonName;
-  })
+  .usage('<addonName> -u <username> -p <password>')
   .option('-u, --username <username>', 'GitHub username')
   .option('-p, --password <password>', 'GitHub password')
-  .parse(process.argv);
+  .action(function(addonName) {
+    if (addonName) {
+      program.addonName = addonName;
+    }
+  });
 
-var options = {
-  addonName: program.addonName ? dasherize(program.addonName) : null,
-  username: program.username ? program.username : null,
-  password: program.password ? program.password : null
-};
+program
+  .parse(process.argv);
 
-return validateOptions(options)
-  .then(run)
-  .catch(ui.error);
+if (program.addonName && program.username && program.password) {
+  require('../tasks/publish')({
+    addonName: dasherize(program.addonName),
+    username: program.username,
+    password: program.password
+  }).catch(ui.error);
+} else {
+  program.outputHelp();
+}