Skip to content

Commit 64f50c6

Browse files
authored
Remove disableHiddenPropDeprioritization flag (facebook#18964)
This is rolled out to 100% public, so we can remove it.
1 parent a30a1c6 commit 64f50c6

10 files changed

+3
-22
lines changed

packages/react-dom/src/client/ReactDOMHostConfig.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ import {
7878
enableModernEventSystem,
7979
enableCreateEventHandleAPI,
8080
enableScopeAPI,
81-
disableHiddenPropDeprioritization,
8281
} from 'shared/ReactFeatureFlags';
8382
import {HostComponent, HostText} from 'react-reconciler/src/ReactWorkTags';
8483
import {TOP_BEFORE_BLUR, TOP_AFTER_BLUR} from '../events/DOMTopLevelEventTypes';
@@ -373,14 +372,9 @@ export function shouldSetTextContent(type: string, props: Props): boolean {
373372
}
374373

375374
export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {
376-
if (disableHiddenPropDeprioritization) {
377-
// This is obnoxiously specific so that nobody uses it, but we can still opt
378-
// in via an infra-level userspace abstraction.
379-
return props.hidden === 'unstable-do-not-use-legacy-hidden';
380-
} else {
381-
// Legacy behavior. Any truthy value works.
382-
return !!props.hidden;
383-
}
375+
// This is obnoxiously specific so that nobody uses it, but we can still opt
376+
// in via an infra-level userspace abstraction.
377+
return props.hidden === 'unstable-do-not-use-legacy-hidden';
384378
}
385379

386380
export function createTextInstance(

packages/shared/ReactFeatureFlags.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,3 @@ export const enableLegacyFBSupport = false;
138138
// expiration time is currently rendering. Remove this flag once we have
139139
// migrated to the new behavior.
140140
export const deferRenderPhaseUpdateToNextBatch = true;
141-
142-
// Flag used by www build so we can log occurrences of legacy hidden API
143-
export const disableHiddenPropDeprioritization = true;

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
4848

4949
export const enableNewReconciler = false;
5050
export const deferRenderPhaseUpdateToNextBatch = true;
51-
export const disableHiddenPropDeprioritization = true;
5251

5352
// Flow magic to verify the exports of this file match the original version.
5453
// eslint-disable-next-line no-unused-vars

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
4747

4848
export const enableNewReconciler = false;
4949
export const deferRenderPhaseUpdateToNextBatch = true;
50-
export const disableHiddenPropDeprioritization = true;
5150

5251
// Flow magic to verify the exports of this file match the original version.
5352
// eslint-disable-next-line no-unused-vars

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
4747

4848
export const enableNewReconciler = false;
4949
export const deferRenderPhaseUpdateToNextBatch = true;
50-
export const disableHiddenPropDeprioritization = true;
5150

5251
// Flow magic to verify the exports of this file match the original version.
5352
// eslint-disable-next-line no-unused-vars

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
4747

4848
export const enableNewReconciler = false;
4949
export const deferRenderPhaseUpdateToNextBatch = true;
50-
export const disableHiddenPropDeprioritization = true;
5150

5251
// Flow magic to verify the exports of this file match the original version.
5352
// eslint-disable-next-line no-unused-vars

packages/shared/forks/ReactFeatureFlags.testing.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
4747

4848
export const enableNewReconciler = false;
4949
export const deferRenderPhaseUpdateToNextBatch = true;
50-
export const disableHiddenPropDeprioritization = true;
5150

5251
// Flow magic to verify the exports of this file match the original version.
5352
// eslint-disable-next-line no-unused-vars

packages/shared/forks/ReactFeatureFlags.testing.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
4747

4848
export const enableNewReconciler = false;
4949
export const deferRenderPhaseUpdateToNextBatch = true;
50-
export const disableHiddenPropDeprioritization = true;
5150

5251
// Flow magic to verify the exports of this file match the original version.
5352
// eslint-disable-next-line no-unused-vars

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ export const enableModernEventSystem = __VARIANT__;
2121
export const enableLegacyFBSupport = __VARIANT__;
2222
export const enableDebugTracing = !__VARIANT__;
2323

24-
// Temporary flag, in case we need to re-enable this feature.
25-
export const disableHiddenPropDeprioritization = __VARIANT__;
26-
2724
// This only has an effect in the new reconciler. But also, the new reconciler
2825
// is only enabled when __VARIANT__ is true. So this is set to the opposite of
2926
// __VARIANT__ so that it's `false` when running against the new reconciler.

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ export const {
2727
enableLegacyFBSupport,
2828
enableDebugTracing,
2929
deferRenderPhaseUpdateToNextBatch,
30-
disableHiddenPropDeprioritization,
3130
} = dynamicFeatureFlags;
3231

3332
// On WWW, __EXPERIMENTAL__ is used for a new modern build.

0 commit comments

Comments
 (0)