Skip to content

Commit 0960b7b

Browse files
authored
Upgrade fbjs-scripts (facebook#18684)
* Upgrade fbjs-scripts This script takes into account the NODE_ENV as part of jest cache keys. This avoids flaky tests since we depend on different transforms in prod and dev. * Upgrade Fresh test to Babel 7 transform
1 parent 5f7b175 commit 0960b7b

File tree

4 files changed

+332
-543
lines changed

4 files changed

+332
-543
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"eslint-plugin-no-for-of-loops": "^1.0.0",
5757
"eslint-plugin-react": "^6.7.1",
5858
"eslint-plugin-react-internal": "link:./scripts/eslint-rules",
59-
"fbjs-scripts": "0.8.3",
59+
"fbjs-scripts": "1.2.0",
6060
"filesize": "^6.0.1",
6161
"flow-bin": "0.97",
6262
"glob": "^7.1.6",

packages/react-refresh/src/__tests__/ReactFreshBabelPlugin-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ describe('ReactFreshBabelPlugin', () => {
415415
}
416416
`,
417417
{
418-
plugins: ['transform-es2015-modules-commonjs'],
418+
plugins: ['@babel/transform-modules-commonjs'],
419419
},
420420
),
421421
).toMatchSnapshot();

packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,13 +289,12 @@ exports[`ReactFreshBabelPlugin includes custom hooks into the signatures when co
289289
Object.defineProperty(exports, "__esModule", {
290290
value: true
291291
});
292-
293-
var _s = $RefreshSig$();
294-
295292
exports.default = App;
296293
297294
var _hooks = require("./hooks");
298295
296+
var _s = $RefreshSig$();
297+
299298
function App() {
300299
_s();
301300

0 commit comments

Comments
 (0)