Harden Cursor post-review hook validation

Author: coderabbitai[bot]

hooks/post-review-context.mjs

@@ -1,4 +1,5 @@
-import { appendFileSync, existsSync, readFileSync, unlinkSync, writeFileSync } from "node:fs";
+import { appendFileSync, existsSync, mkdirSync, readFileSync, unlinkSync, writeFileSync } from "node:fs";
+import { createHash } from "node:crypto";
 import os from "node:os";
 import path from "node:path";
 import process from "node:process";
@@ -34,19 +35,158 @@ function isCodeRabbitReviewCommand(command) {
   if (typeof command !== "string") {
     return false;
   }
-  return /coderabbit(\.exe)?(\s|.*\s)review(\s|$)/.test(command) && !/autofix/.test(command);
+
+  const argv = tokenizeSimpleCommand(command);
+  if (!argv) {
+    return false;
+  }
+
+  const binary = path.basename(argv[0]).toLowerCase();
+  return (
+    ["coderabbit", "coderabbit.exe", "cr", "cr.exe"].includes(binary) &&
+    argv[1] === "review" &&
+    argv.includes("--agent") &&
+    !argv.includes("autofix")
+  );
 }
 
-function looksClean(toolOutput) {
-  if (typeof toolOutput !== "string") {
+function tokenizeSimpleCommand(command) {
+  const argv = [];
+  let token = "";
+  let quote = "";
+  let escaped = false;
+  let hasToken = false;
+
+  for (let index = 0; index < command.length; index += 1) {
+    const char = command[index];
+
+    if (escaped) {
+      token += char;
+      hasToken = true;
+      escaped = false;
+      continue;
+    }
+
+    if (char === "\\") {
+      escaped = true;
+      continue;
+    }
+
+    if (quote) {
+      if (char === quote) {
+        quote = "";
+      } else {
+        token += char;
+        hasToken = true;
+      }
+      continue;
+    }
+
+    if (char === "'" || char === '"') {
+      quote = char;
+      hasToken = true;
+      continue;
+    }
+
+    if (char === "$" && command[index + 1] === "(") {
+      return null;
+    }
+
+    if (char === "#" || char === "\n" || char === "\r" || "|;&<>()`".includes(char)) {
+      return null;
+    }
+
+    if (/\s/.test(char)) {
+      if (hasToken) {
+        argv.push(token);
+        token = "";
+        hasToken = false;
+      }
+      continue;
+    }
+
+    token += char;
+    hasToken = true;
+  }
+
+  if (escaped || quote) {
+    return null;
+  }
+
+  if (hasToken) {
+    argv.push(token);
+  }
+
+  return argv;
+}
+
+function getExitCode(input) {
+  const candidates = [
+    input?.exit_code,
+    input?.exitCode,
+    input?.tool_exit_code,
+    input?.tool_result?.exit_code,
+    input?.tool_result?.exitCode,
+    input?.tool_response?.exit_code,
+    input?.tool_response?.exitCode,
+  ];
+
+  return candidates.find((candidate) => Number.isInteger(candidate));
+}
+
+function toolSucceeded(input) {
+  const exitCode = getExitCode(input);
+  if (exitCode !== undefined && exitCode !== 0) {
     return false;
   }
-  return /(raised|found|reported)\s+0\s+issues|"issues"\s*:\s*\[\s*\]|no issues found/i.test(toolOutput);
+
+  return !(input?.tool_error || input?.error);
+}
+
+function reviewOutcome(toolOutput) {
+  if (typeof toolOutput !== "string") {
+    return null;
+  }
+
+  let completeEvent = null;
+
+  for (const line of toolOutput.split(/\r?\n/)) {
+    const trimmed = line.trim();
+    if (!trimmed) {
+      continue;
+    }
+
+    let event;
+    try {
+      event = JSON.parse(trimmed);
+    } catch {
+      return null;
+    }
+
+    if (event?.type === "error") {
+      return null;
+    }
+
+    if (event?.type === "complete") {
+      completeEvent = event;
+    }
+  }
+
+  if (!completeEvent || !Number.isInteger(completeEvent.findings)) {
+    return null;
+  }
+
+  return completeEvent.findings === 0 ? "clean" : "issues";
 }
 
 function statePath(input) {
-  const key = String(input?.conversation_id || input?.generation_id || "global").replace(/[^A-Za-z0-9_-]/g, "");
-  return path.join(os.tmpdir(), `coderabbit-clean-review-${key || "global"}.json`);
+  const key = String(input?.conversation_id || input?.generation_id || "global");
+  const digest = createHash("sha256").update(key).digest("hex").slice(0, 32);
+  const baseDir =
+    process.env.XDG_STATE_HOME || (os.homedir() ? path.join(os.homedir(), ".local", "state") : os.tmpdir());
+  const dir = path.join(baseDir, "coderabbit", "cursor-plugin");
+  mkdirSync(dir, { recursive: true, mode: 0o700 });
+  return path.join(dir, `clean-review-${digest}.json`);
 }
 
 function emit(context) {
@@ -67,20 +207,24 @@ const toolName = input?.tool_name ?? "unknown";
 const command = input?.tool_input?.command;
 const snippet = typeof command === "string" ? command.slice(0, 100) : "";
 
-if (isCodeRabbitReviewCommand(command)) {
-  const clean = looksClean(input?.tool_output);
-  log(`review-complete tool=${toolName} clean=${clean} cmd=${snippet}`);
+if (isCodeRabbitReviewCommand(command) && toolSucceeded(input)) {
+  const outcome = reviewOutcome(input?.tool_output);
+  log(`review-complete tool=${toolName} outcome=${outcome ?? "unknown"} cmd=${snippet}`);
 
-  if (clean) {
+  if (outcome === "clean") {
     try {
-      writeFileSync(statePath(input), JSON.stringify({ expires: Date.now() + REMINDER_WINDOW_MS, remaining: REMINDER_MAX }));
+      writeFileSync(
+        statePath(input),
+        JSON.stringify({ expires: Date.now() + REMINDER_WINDOW_MS, remaining: REMINDER_MAX }),
+        { mode: 0o600 },
+      );
     } catch {
       // State is best-effort; the primary injection below still happens.
     }
     emit(
       "The CodeRabbit review for this request is complete and came back clean, meaning the changes passed review. Present a clean-result summary: what was reviewed (files changed, lines, scope), what it was checked for (bugs, security issues, code quality risks), confirmation that the changes passed, and suggested next steps such as running tests, committing, or opening a PR. Then finish the response there; the review request is fulfilled, so a second AI or manual pass over the same diff is not needed. Linters, type checkers, and tests remain available whenever the project workflow calls for them.",
     );
-  } else {
+  } else if (outcome === "issues") {
     try {
       unlinkSync(statePath(input));
     } catch {
@@ -89,6 +233,8 @@ if (isCodeRabbitReviewCommand(command)) {
     emit(
       "The CodeRabbit review for this request is complete. Present the parsed results grouped by severity and finish the response there; the review request is fulfilled. A second AI or manual pass over the same diff is not needed. Linters, type checkers, and tests remain available whenever the project workflow calls for them.",
     );
+  } else {
+    log(`pass unrecognized-agent-output tool=${toolName} cmd=${snippet}`);
   }
   process.exit(0);
 }

package.json

@@ -6,7 +6,7 @@
   "license": "MIT",
   "type": "module",
   "scripts": {
-    "test": "node scripts/validate-plugin.mjs",
+    "test": "node scripts/test-post-review-context.mjs && node scripts/validate-plugin.mjs",
     "validate": "node scripts/validate-plugin.mjs"
   },
   "engines": {