File tree Expand file tree Collapse file tree 3 files changed +2
-27
lines changed Expand file tree Collapse file tree 3 files changed +2
-27
lines changed Original file line number Diff line number Diff line change @@ -422,22 +422,6 @@ func Test_selectDeflate(t *testing.T) {
422422 },
423423 expOK : true ,
424424 },
425- // {
426- // name: "x-webkit-deflate-frame",
427- // mode: CompressionNoContextTakeover,
428- // reqSecWebSocketExtensions: "x-webkit-deflate-frame; no_context_takeover",
429- // respSecWebSocketExtensions: "x-webkit-deflate-frame; no_context_takeover",
430- // expCopts: &compressionOptions{
431- // clientNoContextTakeover: true,
432- // serverNoContextTakeover: true,
433- // },
434- // },
435- // {
436- // name: "x-webkit-deflate/error",
437- // mode: CompressionNoContextTakeover,
438- // reqSecWebSocketExtensions: "x-webkit-deflate-frame; max_window_bits",
439- // error: true,
440- // },
441425 }
442426
443427 for _ , tc := range testCases {
Original file line number Diff line number Diff line change @@ -12,11 +12,7 @@ import (
1212// CompressionMode represents the modes available to the deflate extension.
1313// See https://tools.ietf.org/html/rfc7692
1414//
15- // A compatibility layer is implemented for the older deflate-frame extension used
16- // by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
17- // It will work the same in every way except that we cannot signal to the peer we
18- // want to use no context takeover on our side, we can only signal that they should.
19- // But it is currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
15+ // Works in all browsers except Safari which does not implement the deflate extension.
2016type CompressionMode int
2117
2218const (
Original file line number Diff line number Diff line change @@ -485,12 +485,7 @@ func CloseStatus(err error) StatusCode {
485485
486486// CompressionMode represents the modes available to the deflate extension.
487487// See https://tools.ietf.org/html/rfc7692
488- //
489- // A compatibility layer is implemented for the older deflate-frame extension used
490- // by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
491- // It will work the same in every way except that we cannot signal to the peer we
492- // want to use no context takeover on our side, we can only signal that they should.
493- // It is however currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
488+ // Works in all browsers except Safari which does not implement the deflate extension.
494489type CompressionMode int
495490
496491const (
You can’t perform that action at this time.
0 commit comments