Add registry mirror environment variable option #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KANIKO_REGISTRY_MIRROR environment variable can set to mirror of docker hub. Useful when rate limited by docker hub.
kylecarbs
approved these changes
Mar 26, 2024
envbuilder.go
Outdated
| @@ -656,6 +656,7 @@ func Run(ctx context.Context, options Options) error { | |||
| Insecure: options.Insecure, | |||
| InsecurePull: options.Insecure, | |||
| SkipTLSVerify: options.Insecure, | |||
| RegistryMirrors: strings.Split(os.Getenv("KANIKO_REGISTRY_MIRROR"), ";"), | |||
There was a problem hiding this comment.
What do you think about splitting on instead? ; seems a bit less standard to me.
It'd be great to add a comment linking to this PR and these docs.
There was a problem hiding this comment.
I references the environment variable design in Kaniko (link), it uses ; to separate multiple registry map.
I think it might be better if we follows Kaniko's environment variable format.
kylecarbs
approved these changes
Mar 26, 2024
Deals with thet case when the KANIKO_REGISTRY_MIRROR is not set.
kylecarbs
requested changes
Mar 26, 2024
kylecarbs
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
KANIKO_REGISTRY_MIRRORenvironment variable that can set mirrors for docker hub.Useful when rate limited by docker hub.