Skip to content

update example docker command port bind options #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019
Merged

update example docker command port bind options #88

merged 1 commit into from
Mar 7, 2019

Conversation

Omeryl
Copy link
Contributor

@Omeryl Omeryl commented Mar 7, 2019

The existing command errors out with

docker: invalid publish opts format (should be name=value but got 'localhost:8443:8443').

it needs to explicitly use an IP and not a hostname.

must use 127.0.0.1 and not `localhost`
@Omeryl
Copy link
Contributor Author

Omeryl commented Mar 7, 2019

CI failing is unrelated, given it's only updating a markdown file.

@kylecarbs kylecarbs requested review from nhooyr and removed request for kylecarbs and code-asher March 7, 2019 17:20
@kylecarbs kylecarbs merged commit 8e68411 into coder:master Mar 7, 2019
@coadler
Copy link
Contributor

coadler commented Mar 7, 2019

@kylecarbs this also needs to be fixed on the homepage

@Omeryl Omeryl deleted the patch-1 branch March 7, 2019 20:39
code-asher pushed a commit that referenced this pull request Jun 19, 2019
must use 127.0.0.1 and not `localhost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants