Skip to content

fix an integration test error #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lifubang
Copy link

Signed-off-by: lifubang lifubang@acmcoder.com

acmcoder@acmcoder:~/dev/code-server$ # **Before this patch**
acmcoder@acmcoder:~/dev/code-server$ yarn test:integration
yarn run v1.22.19
$ ./ci/dev/test-integration.sh
Set CODE_SERVER_PATH to test another build of code-server
Running tests with code-server binary: 'release-standalone/bin/code-server'
 FAIL  test/integration/listExtensions.test.ts
  ● Test suite failed to run

    test/integration/listExtensions.test.ts:24:11 - error TS2554: Expected 2 arguments, but got 1.

    24     await rename(path.join(tempPathToUnpackedExtension, "extension", pathToUnpackedExtension))
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

      node_modules/@types/node/fs/promises.d.ts:243:40
        243     function rename(oldPath: PathLike, newPath: PathLike): Promise<void>;
                                                   ~~~~~~~~~~~~~~~~~
        An argument for 'newPath' was not provided.

 PASS  test/integration/installExtension.test.ts (13.392 s)

Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        14.205 s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
acmcoder@acmcoder:~/dev/code-server$ # **After the patch**
acmcoder@acmcoder:~/dev/code-server$ yarn test:integration
yarn run v1.22.19
$ ./ci/dev/test-integration.sh
Set CODE_SERVER_PATH to test another build of code-server
Running tests with code-server binary: 'release-standalone/bin/code-server'
 PASS  test/integration/listExtensions.test.ts (9.092 s)
 PASS  test/integration/installExtension.test.ts (11.598 s)

Test Suites: 2 passed, 2 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        12.406 s, estimated 14 s
Ran all test suites.
Done in 21.02s.

Signed-off-by: lifubang <lifubang@acmcoder.com>
@lifubang lifubang requested a review from a team June 26, 2022 01:41
@jsjoeio jsjoeio self-assigned this Jun 27, 2022
@jsjoeio jsjoeio added this to the June 2022 milestone Jun 27, 2022
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how that made it in? Thank you for fixing it!

@jsjoeio jsjoeio enabled auto-merge (squash) June 27, 2022 15:04
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #5300 (5a9ff22) into main (c51ff3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5300   +/-   ##
=======================================
  Coverage   72.47%   72.47%           
=======================================
  Files          30       30           
  Lines        1671     1671           
  Branches      367      367           
=======================================
  Hits         1211     1211           
  Misses        397      397           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51ff3b...5a9ff22. Read the comment docs.

@jsjoeio jsjoeio disabled auto-merge June 27, 2022 21:31
@jsjoeio jsjoeio enabled auto-merge (squash) June 27, 2022 21:32
@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 27, 2022

I'm going to fix the audit-ci job in another PR and then merge this.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 28, 2022

I ended up making this fix in 336b5a0 - thanks for bringing this to our attention!

@jsjoeio jsjoeio closed this Jun 28, 2022
auto-merge was automatically disabled June 28, 2022 19:58

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants