Skip to content

Vscode 1.52.1 #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 9, 2021
Merged

Vscode 1.52.1 #2543

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e4a830e
Squashed 'lib/vscode/' changes from e5a624b788..3e344b17b7
code-asher Feb 9, 2021
859de79
Update to VS Code 1.52.1
code-asher Feb 9, 2021
9221efc
Restore Node check
code-asher Feb 9, 2021
0a1a8fe
Remove new .yarnrc
code-asher Feb 9, 2021
80d5005
Remove electron and resolve yarn.lock conflict
code-asher Feb 9, 2021
14c96d7
Remove added logLevel
code-asher Feb 9, 2021
89c38d3
Update storage promise
code-asher Feb 9, 2021
cc59279
Remove GoHomeContributor
code-asher Feb 9, 2021
f8d546b
Remove hidden home CSS
code-asher Feb 9, 2021
a6d4b24
Resolve extensions viewlet conflicts
code-asher Feb 9, 2021
a652318
Fall back to remote extension server on web
code-asher Feb 9, 2021
068e399
Remove Node browser shim
code-asher Feb 9, 2021
948e01f
Bundle jpg from VS Code
code-asher Feb 9, 2021
898565e
Resolve browser telemetry conflict
code-asher Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore Node check 
Since we're following the VS Code allowed version range now to prevent
bugs use the new range instead of commenting it out.
  • Loading branch information
@code-asher
code-asher committed Feb 9, 2021
commit 9221efc104ee83271a7b6a8f4d9bb6cc9c48c7d0
7 changes: 0 additions & 7 deletions lib/vscode/build/npm/preinstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,9 @@ let err = false;

const majorNodeVersion = parseInt(/^(\d+)\./.exec(process.versions.node)[1]);

<<<<<<< HEAD
if (majorNodeVersion < 10 || majorNodeVersion >= 13) {
// We are ok building above Node 12.
// console.error('\033[1;31m*** Please use node >=10 and <=12.\033[0;0m');
// err = true;
=======
if (majorNodeVersion < 10 || majorNodeVersion >= 16) {
console.error('\033[1;31m*** Please use node >=10 and <=16.\033[0;0m');
err = true;
>>>>>>> e4a830e9b7ca039c7c70697786d29f5b6679d775
}

const cp = require('child_process');
Expand Down