Dead code #1927
Merged
Dead code #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dashboard - app api
A provider can now be registered on multiple endpoints (or potentially moved if needed).
It can still be used to check for updates but will not apply them. For now also remove the update check loop in VS Code since it's currently unused (update check is hardcoded off right now) and won't work anyway since it also applies the update which now won't work. In the future we should integrate the check into the browser update service.
This is for applications like Jupyter that aren't base path agnostic.
nhooyr
approved these changes
Jul 30, 2020
| const providers = Array.from(this.providers.values()) | ||
| // Catch so all the errors can be seen rather than just the first one. | ||
| const responses = await Promise.all<Error | undefined>(providers.map((p) => p.dispose().catch((e) => e))) | ||
| return responses.filter<Error>((r): r is Error => typeof r !== "undefined") |
There was a problem hiding this comment.
Why do we need to use typeof here versus !== undefined?
There was a problem hiding this comment.
Practically no difference, just a stylistic choice. It might be because I'm thinking of it in terms of the type rather than the value. It parallels what I'd do if I wanted to filter strings instead, and I like the consistency. It also works for undeclared variables, further enforcing the consistency.
It might also be partly force of habit from back when you could overwrite undefined on the global object. 😛
But even though the global undefined is read-only now it still feels weird to me that I can do const undefined = "something" and now my checks have a different meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all the code not currently in use.