Skip to content

Commit e0e3bb5

Browse files
committed
fixup
1 parent 16dc68e commit e0e3bb5

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

test/e2e/extensions.test.ts

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,32 +8,27 @@ function runTestExtensionTests() {
88
test("should have access to VSCODE_PROXY_URI", async ({ codeServerPage }) => {
99
const address = await getMaybeProxiedCodeServer(codeServerPage)
1010

11-
// TODO@jsjoeio - here... we need to reload until selector is available
12-
// maybe something like
13-
// isExtensionLoaded
14-
// reloadUntilExtensionLoaded
11+
await codeServerPage.reloadUntilTestExtensionIsLoaded()
1512
await codeServerPage.executeCommandViaMenus("code-server: Get proxy URI")
1613

17-
await codeServerPage.page.waitForSelector(".notification-list-item-message", {
18-
timeout: 3000
19-
})
20-
const text = await codeServerPage.page.locator(".notification-list-item-message").textContent()
14+
await codeServerPage.page.waitForSelector("text=proxyUri", { timeout: 3000 })
15+
const text = await codeServerPage.page.locator("text=proxyUri").first().textContent()
2116
// Remove end slash in address
2217
const normalizedAddress = address.replace(/\/+$/, "")
23-
expect(text).toBe(`${normalizedAddress}/proxy/{{port}}`)
18+
expect(text).toBe(`Info: proxyUri: ${normalizedAddress}/proxy/{{port}}`)
2419
})
2520
}
2621

2722
const flags = ["--extensions-dir", path.join(__dirname, "./extensions")]
2823

29-
describe("Extensions", flags, {}, () => {
30-
runTestExtensionTests()
31-
})
24+
// describe("Extensions", flags, {}, () => {
25+
// runTestExtensionTests()
26+
// })
3227

3328
if (process.env.USE_PROXY !== "1") {
3429
describe("Extensions with --cert", [...flags, "--cert"], {}, () => {
3530
runTestExtensionTests()
36-
})
31+
}, )
3732
} else {
3833
base.describe("Extensions with --cert", () => {
3934
base.skip("skipped because USE_PROXY is set", () => {

0 commit comments

Comments
 (0)