Skip to content

Commit 9c71a39

Browse files
committed
fixup: refactor and delete old methods
1 parent 7906ebf commit 9c71a39

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

test/e2e/extensions.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ function runTestExtensionTests() {
88
test("should have access to VSCODE_PROXY_URI", async ({ codeServerPage }) => {
99
const address = await getMaybeProxiedCodeServer(codeServerPage)
1010

11-
// await codeServerPage.reloadUntilTestExtensionIsLoaded()
1211
await codeServerPage.waitForTestExtensionLoaded()
1312
await codeServerPage.executeCommandViaMenus("code-server: Get proxy URI")
1413

test/e2e/models/CodeServer.ts

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -282,32 +282,6 @@ export class CodeServerPage {
282282
this.codeServer.logger.debug("Editor is ready!")
283283
}
284284

285-
/**
286-
* Checks if the test extension has loaded
287-
*
288-
* Reload until both checks pass
289-
*/
290-
async reloadUntilTestExtensionIsLoaded() {
291-
this.codeServer.logger.debug("Waiting for test extension to load...")
292-
293-
const extensionIsLoaded = await this.isTestExtensionLoaded()
294-
let reloadCount = 0
295-
296-
while (!extensionIsLoaded) {
297-
await this.page.waitForLoadState("load")
298-
// Give it an extra second just in case it's feeling extra slow
299-
await this.page.waitForTimeout(1000)
300-
reloadCount += 1
301-
if (await this.isTestExtensionLoaded()) {
302-
this.codeServer.logger.debug(`test extension loaded after ${reloadCount} reloads`)
303-
break
304-
}
305-
await this.reloadUntilEditorIsReady()
306-
}
307-
308-
this.codeServer.logger.debug("Test extension has loaded!")
309-
}
310-
311285
/**
312286
* Checks if the editor is visible
313287
*/
@@ -322,20 +296,6 @@ export class CodeServerPage {
322296
return visible
323297
}
324298

325-
/**
326-
* Checks if the test extension loaded
327-
*/
328-
async isTestExtensionLoaded() {
329-
const selector = "text=test extension loaded"
330-
this.codeServer.logger.debug("Waiting for test extension to load...")
331-
332-
const loaded = await this.page.isVisible(selector)
333-
334-
this.codeServer.logger.debug(`Test extension has ${loaded ? "" : "not"} loaded`)
335-
336-
return loaded
337-
}
338-
339299
/**
340300
* Checks if the test extension loaded
341301
*/

0 commit comments

Comments
 (0)