Flesh out protocol clean up. WIP

Author: GirlBossRush

lib/vscode/package.json

@@ -60,6 +60,7 @@
   "dependencies": {
     "applicationinsights": "1.0.8",
     "chokidar": "3.5.1",
+    "express": "^5.0.0-alpha.8",
     "graceful-fs": "4.2.6",
     "http-proxy-agent": "^2.1.0",
     "https-proxy-agent": "^2.2.3",
@@ -91,23 +92,23 @@
     "yazl": "^2.4.3"
   },
   "devDependencies": {
-    "7zip": "0.0.6",
-    "@types/proxy-from-env": "^1.0.1",
-    "@types/tar-stream": "^2.2.1",
     "@types/applicationinsights": "0.20.0",
     "@types/chokidar": "2.1.3",
     "@types/cookie": "^0.3.3",
     "@types/copy-webpack-plugin": "^6.0.3",
     "@types/cssnano": "^4.0.0",
     "@types/debug": "4.1.5",
+    "@types/express": "^4.17.8",
     "@types/graceful-fs": "4.1.2",
     "@types/gulp-postcss": "^8.0.0",
     "@types/http-proxy-agent": "^2.0.1",
     "@types/keytar": "^4.4.0",
     "@types/minimist": "^1.2.1",
     "@types/mocha": "^8.2.0",
     "@types/node": "14.x",
+    "@types/proxy-from-env": "^1.0.1",
     "@types/sinon": "^1.16.36",
+    "@types/tar-stream": "^2.2.1",
     "@types/trusted-types": "^1.0.6",
     "@types/vscode-windows-registry": "^1.0.0",
     "@types/webpack": "^4.41.25",
@@ -120,6 +121,7 @@
     "@types/yazl": "^2.4.2",
     "@typescript-eslint/eslint-plugin": "3.2.0",
     "@typescript-eslint/parser": "^3.3.0",
+    "7zip": "0.0.6",
     "ansi-colors": "^3.2.3",
     "asar": "^3.0.3",
     "chromium-pickle-js": "^0.2.0",
@@ -129,14 +131,13 @@
     "cssnano": "^5.0.2",
     "debounce": "^1.0.0",
     "deemon": "^1.4.0",
-    "eslint": "6.8.0",
     "eslint-plugin-jsdoc": "^19.1.0",
+    "eslint": "6.8.0",
     "event-stream": "3.3.4",
     "fancy-log": "^1.3.3",
     "fast-plist": "0.1.2",
     "file-loader": "^4.2.0",
     "glob": "^5.0.13",
-    "gulp": "^4.0.0",
     "gulp-bom": "^3.0.0",
     "gulp-buffer": "0.0.2",
     "gulp-concat": "^2.6.1",
@@ -155,6 +156,7 @@
     "gulp-sourcemaps": "^3.0.0",
     "gulp-tsb": "4.0.6",
     "gulp-vinyl-zip": "^2.1.2",
+    "gulp": "^4.0.0",
     "husky": "^0.13.1",
     "innosetup": "6.0.5",
     "is": "^3.1.0",
@@ -170,9 +172,9 @@
     "minimatch": "^3.0.4",
     "minimist": "^1.2.5",
     "mkdirp": "^1.0.4",
-    "mocha": "^8.2.1",
     "mocha-junit-reporter": "^2.0.0",
     "mocha-multi-reporters": "^1.5.1",
+    "mocha": "^8.2.1",
     "npm-run-all": "^4.1.5",
     "opn": "^6.0.0",
     "optimist": "0.3.5",
@@ -184,22 +186,22 @@
     "rcedit": "^1.1.0",
     "request": "^2.85.0",
     "sinon": "^1.17.2",
-    "source-map": "0.6.1",
     "source-map-support": "^0.3.2",
+    "source-map": "0.6.1",
     "style-loader": "^1.0.0",
     "ts-loader": "^6.2.1",
     "tsec": "0.1.4",
-    "typescript": "^4.4.0-dev.20210528",
     "typescript-formatter": "7.1.0",
+    "typescript": "^4.4.0-dev.20210528",
     "underscore": "^1.12.1",
-    "vinyl": "^2.0.0",
     "vinyl-fs": "^3.0.0",
+    "vinyl": "^2.0.0",
     "vscode-debugprotocol": "1.47.0",
     "vscode-nls-dev": "^3.3.1",
     "vscode-telemetry-extractor": "^1.7.0",
-    "webpack": "^4.43.0",
     "webpack-cli": "^3.3.12",
     "webpack-stream": "^5.2.1",
+    "webpack": "^4.43.0",
     "xml2js": "^0.4.17",
     "yaserver": "^0.2.0"
   },

lib/vscode/src/vs/base/common/ipc.d.ts

@@ -34,6 +34,8 @@ export interface IProductConfiguration {
 	/** @coder BEGIN */
 	/** @deprecated Should be replaced with code-oss version. */
 	readonly codeServerVersion?: string;
+	readonly authed?: boolean;
+	readonly logoutEndpointUrl: string;
 	/** @coder END */
 
 	readonly version: string;

lib/vscode/src/vs/base/common/product.ts

@@ -279,7 +279,13 @@ export type Complete<T> = {
 	[P in keyof Required<T>]: Pick<T, P> extends Required<Pick<T, P>> ? T[P] : (NonNullable<T[P]>);
 };
 
+/**
+ * Marks readonly properties as wriatable.
+ */
+export type Writeable<T> = { -readonly [P in keyof T]: T[P] };
+
 export function NotImplementedProxy<T>(name: string): { new(): T } {
+
 	return <any>class {
 		constructor() {
 			return new Proxy({}, {

lib/vscode/src/vs/base/common/types.ts

@@ -756,11 +756,6 @@ export class PersistentProtocol implements IMessagePassingProtocol {
 		return this._socket;
 	}
 
-	// NOTE@coder: add setSocket
-	public setSocket(socket: ISocket) {
-		this._socket = socket;
-	}
-
 	public getMillisSinceLastIncomingData(): number {
 		return Date.now() - this._socketReader.lastReadTime;
 	}