Skip to content

Commit 50ed29e

Browse files
committed
Move rimraf to prod deps in extensions
The postinstall uses rimraf so it needs to exist in the final build.
1 parent 638ab7c commit 50ed29e

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

ci/build/npm-postinstall.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ vscode_yarn() {
3535
cd lib/vscode
3636
yarn --production --frozen-lockfile
3737
cd extensions
38-
# Cannot use --production here. The postinstall here uses a dev dependency.
39-
yarn --frozen-lockfile
38+
yarn --production --frozen-lockfile
4039
}
4140

4241
main "$@"

ci/dev/vscode.patch

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,26 @@ index 0000000000..88b720ceee
217217
+ util.rimraf("out-vscode-min"),
218218
+ common.minifyTask("out-vscode")
219219
+));
220+
diff --git a/extensions/package.json b/extensions/package.json
221+
index 7c668c9744..0778f4f7db 100644
222+
--- a/extensions/package.json
223+
+++ b/extensions/package.json
224+
@@ -2,13 +2,14 @@
225+
"name": "vscode-extensions",
226+
"version": "0.0.1",
227+
"description": "Dependencies shared by all extensions",
228+
+ "dependencies_comment": "Move rimraf to dependencies because it is used in the postinstall script.",
229+
"dependencies": {
230+
+ "rimraf": "^3.0.2",
231+
"typescript": "3.9.6"
232+
},
233+
"scripts": {
234+
"postinstall": "node ./postinstall"
235+
},
236+
"devDependencies": {
237+
- "rimraf": "^3.0.2"
238+
}
239+
}
220240
diff --git a/package.json b/package.json
221241
index 86e3d5140d..2e52256e49 100644
222242
--- a/package.json

0 commit comments

Comments
 (0)