Fix dialog items getting cut off

code-asher · code-asher · commit 362715bbeb68 · 2019-06-07T14:30:45.000-05:00
Fixes #336.
diff --git a/packages/vscode/src/dialog.ts b/packages/vscode/src/dialog.ts
@@ -315,7 +315,6 @@ class Dialog {
 		}
 		buttonsNode.appendChild(confirmBtn);
 		this.root.appendChild(buttonsNode);
-		this.entryList.layout();
 
 		this.path = options.defaultPath || "/";
 	}
@@ -391,6 +390,8 @@ class Dialog {
 				return true;
 			});
 
+			this.entryList.layout();
+
 			this.entryList.setChildren(null, items.map((i: DialogEntry): ITreeElement<DialogEntry> => ({ element: i })));
 			this.entryList.domFocus();
 			this.entryList.setFocus([null]);

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,6 @@ class Dialog {`
`315`	`315`	`}`
`316`	`316`	`buttonsNode.appendChild(confirmBtn);`
`317`	`317`	`this.root.appendChild(buttonsNode);`
`318`		`- this.entryList.layout();`
`319`	`318`
`320`	`319`	`this.path = options.defaultPath \|\| "/";`
`321`	`320`	`}`
`@@ -391,6 +390,8 @@ class Dialog {`
`391`	`390`	`return true;`
`392`	`391`	`});`
`393`	`392`
	`393`	`+ this.entryList.layout();`
	`394`	`+`
`394`	`395`	`this.entryList.setChildren(null, items.map((i: DialogEntry): ITreeElement<DialogEntry> => ({ element: i })));`
`395`	`396`	`this.entryList.domFocus();`
`396`	`397`	`this.entryList.setFocus([null]);`