Switch to strings.EqualFold (hashicorp#5284)

Author: kalafut

builtin/audit/file/backend.go

@@ -33,10 +33,10 @@ func Factory(ctx context.Context, conf *audit.BackendConfig) (audit.Backend, err
 	}
 
 	// normalize path if configured for stdout
-	if strings.ToLower(path) == "stdout" {
+	if strings.EqualFold(path, "stdout") {
 		path = "stdout"
 	}
-	if strings.ToLower(path) == "discard" {
+	if strings.EqualFold(path, "discard") {
 		path = "discard"
 	}
 

builtin/credential/aws/path_login.go

@@ -1394,7 +1394,7 @@ func parseIamArn(iamArn string) (*iamEntity, error) {
 func validateVaultHeaderValue(headers http.Header, requestUrl *url.URL, requiredHeaderValue string) error {
 	providedValue := ""
 	for k, v := range headers {
-		if strings.ToLower(iamServerIdHeader) == strings.ToLower(k) {
+		if strings.EqualFold(iamServerIdHeader, k) {
 			providedValue = strings.Join(v, ",")
 			break
 		}

builtin/credential/github/path_login.go

@@ -196,7 +196,7 @@ func (b *backend) verifyCredentials(ctx context.Context, req *logical.Request, t
 	}
 
 	for _, o := range allOrgs {
-		if strings.ToLower(*o.Login) == strings.ToLower(config.Organization) {
+		if strings.EqualFold(*o.Login, config.Organization) {
 			org = o
 			break
 		}

builtin/credential/okta/path_groups.go

@@ -62,7 +62,7 @@ func (b *backend) Group(ctx context.Context, s logical.Storage, n string) (*Grou
 			return nil, "", err
 		}
 		for _, groupName := range entries {
-			if strings.ToLower(groupName) == strings.ToLower(n) {
+			if strings.EqualFold(groupName, n) {
 				entry, err = s.Get(ctx, "group/"+groupName)
 				if err != nil {
 					return nil, "", err

builtin/logical/pki/cert_util.go

@@ -501,7 +501,7 @@ func parseOtherSANs(others []string) (map[string][]string, error) {
 		if len(splitType) != 2 {
 			return nil, fmt.Errorf("expected a colon in other SAN %q", other)
 		}
-		if strings.ToLower(splitType[0]) != "utf8" {
+		if !strings.EqualFold(splitType[0], "utf8") {
 			return nil, fmt.Errorf("only utf8 other SANs are supported; found non-supported type in other SAN %q", other)
 		}
 		result[splitOther[0]] = append(result[splitOther[0]], splitType[1])