Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CRA with vite #468

Merged
merged 10 commits into from
Aug 25, 2023
Merged

Replace CRA with vite #468

merged 10 commits into from
Aug 25, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Aug 25, 2023

CRA has many problems:

  1. It is deprecated: even no longer recommended by the React team
  2. Webpack is complex to deal with. E.g., we had to use "react-app-rewired" walkaround to make Monaco editor in CRA's webpack bundler.

Vite is simple and nice. One bonus: Vite has a much better Hot Module Replacement (HMR), the hot-reloading experience is now much better (previously was pretty much unusable).

Some changes from vanilla Vite scaffolding:

  1. listen on --host; listen on port 3000, set HMR WS forwarding in nginx.conf
  2. fix App.css styling issues
  3. set "experimentalDecorators": true, in tsconfig, and set { tsDecorators: true } in vite.config to allow Remirror's decorators.

@lihebi lihebi merged commit 2630aa7 into codepod-io:main Aug 25, 2023
This was referenced Aug 25, 2023
@senwang86
Copy link
Collaborator

  • Seems like Canvas shrinked in Chrome and Safari
Screenshot 2023-08-24 at 9 17 20 PM
  • It applies Mac's default theme setting.
Screenshot 2023-08-24 at 9 20 55 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants