-
Notifications
You must be signed in to change notification settings - Fork 2
Implement SYCL code cache #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SYCL code cache #1
Conversation
The current PR only moves the Here, there is a number of additional CUTLASS-related options. If they're interesting for our CUTLASS code generation, we could either duplicate them or also move them to the common config. |
Yes thanks @sommerlukas, indeed a lot can be factorized outside a sycl or cuda scope and I'm seeing this at multiple levels, this would be co-designed alongside the rest of the codegen & template/kernel classes, namely the |
Do you want this to be done or later on? My thinking so far was that we would extract the options once we use them for SYCL code generation in future PRs. |
Agree I guess it's better if we keep it for the next PRs so it makes more sense with the upcoming changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks Lukas for the 1st PR!
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
219a894
to
01b54ec
Compare
Rebased this branch, example still working correctly. Merging now. |
Implement a `SYCLCodeCache` similar to the `CUDACodeCache` for compilation of CUTLASS code for integration of the CUTLASS SYCL backend into Pytorch TorchInductor. Also changes the third-party submodule for CUTLASS to use Codeplay's fork with the SYCL backend. --------- Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Implement a
SYCLCodeCache
similar to theCUDACodeCache
for compilation of CUTLASS code for integration of the CUTLASS SYCL backend into Pytorch TorchInductor.Also changes the third-party submodule for CUTLASS to use Codeplay's fork with the SYCL backend.