This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Create config dir, if it isn't existent in main framework instead of Bootstrap Launcher #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bootstrap Launcher On the first start the default config should be saved, which fails if the folder doesn't exist. This creates a problem when you try to login to the gui. The framework can't be loaded because the config with plugins and connectors don't exist and you won't be able to login, until you create the config directory and restart. A check for the config dir was in the Bootstrap Launcher, but when you run Chat Overflow in IntelliJ that check isn't working. So I added that check in the main framework.
|
Note: This check also exists in the CredentialsService, but checking two times is probably more failure resistant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the first start the default config should be saved, which fails if the folder doesn't exist. This creates a problem when you try to login to the gui. The framework can't be loaded because the config with plugins and connectors don't exist and you won't be able to login, until you create the config directory and restart.
A check for the config dir was in the Bootstrap Launcher, but when you run Chat Overflow in IntelliJ that check isn't working. So I added that check in the main framework.