Added new parameter

[derNiklaas]

Closes #54

Added:

• Integer parameter
• Double parameter
• Boolean parameter
• List parameter
• Map parameter
• Color parameter
• URI / URL parameter
• Time parameter

API Pullrequest: codeoverflow-org/chatoverflow-api#18

[justgerd]

Good, but a few parts of the code are unnecessary complicated.

[J0B10]

Sorry but I think the map and list code is still .

It would be way cleaner to just use the scala collections and return the java versions by using .asJava.
I agreed with skate that this changes should be made but if you can finish them fast we might be able to include your PR in pre-alpha3 as you requested 😄.

Also Url, LocalTime, LocalDate and LocalDateTime parameters are still missing 😉.
If you really don't want to do them I can do It once you are finished.

[derNiklaas]

@joblo2213 Hi there. Thanks for the feedback.
I added a URI parameter (can be converted to URL by using URI.toURL() ). also converted java map/list to scala map/list. Also added comments to the regex.

Could you do the time parameter?

[J0B10]

After commit aacdd21 and the changes @daniel0611 requested I think there is some confusion about how exception handling should work for the parameters:

I think it should be the following way:
Any exceptions that are thrown in deserialize() should get passed.

https://github.com/derNiklaas/chatoverflow/blob/e5bbc816311c92d48d59caa50a974bc9ea14140b/src/main/scala/org/codeoverflow/chatoverflow/configuration/ConfigurationService.scala#L290-L301:

            try {
              val reqContent = loadedRequirementType.get.newInstance().asInstanceOf[io.Serializable]
              requirements.getAccess.setRequirementContent(requirementId, reqContent)
              reqContent.deserialize(content)


              logger info s"Created requirement content for '$requirementId' and deserialized its content."
              true
            } catch {
              case e: Exception =>
                logger error s"Unable to instantiate requirement content. Exception: ${e.getMessage}"
                false
            }

Here all exceptions that are thown while deserializing are cought and logged, and the framework keeps the information that not all requirements could be fullfilled so that it could also be displayed to the gui.

Thats why form my point of view no messages need to be logged and all exceptions may be uncought.
Also if the deserialization failed (like in the ColorPrameter) an exception should be thrown.

The only thing we may think about is making sure that the message of the exception does tell the user what actually is wrong.

[derNiklaas]

Just removed Error handlers from Parameter classes.

exception handling is now fine

[derNiklaas]

895f22f fixed an bug which was introduced by b93b859 .

(test;test2),(test3;test4),(test5,test6) would turn into (test;test2),(test3;test4),(;) which shouldn't happen.
it now throws an IllegalArgumentException.