This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Implement Coursier for plugin dependency resolution and fetching #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ride plugin dependencies
This was referenced Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Coursier to download dependencies that are required by plugins and the sbt auto-plugin to include the pom files of plugins inside the jar like discussed in #105.
The sbt plugin is automatically in all projects active unless deactivated like this PR does for the framework.
This PR also updates the
PluginClassLoaderto always have the platform/extension class loader as it's parent. This ensures that plugins get the dependencies of their pom file. If the same class of a dependency also exists in the classloader of the framework the class of the framework would have higher priority than the one in the plugin class loader. By having the platform/extension class loader as a parent the class can only come from java or the plugin class loader with the wanted version of the dependencies added.A caching class loader isn't in this PR tough. I don't have enough time for that before my vacation.
API PR: codeoverflow-org/chatoverflow-api#15
Plugins-public PR: codeoverflow-org/chatoverflow-plugins#2