Implemented changes from @justgerd

Author: derNiklaas

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/ListParameterImpl.scala

@@ -1,13 +1,11 @@
 package org.codeoverflow.chatoverflow.requirement.parameter
 
-import java.util.Collections
 import java.util.List
 
 import collection.JavaConverters._
 import org.codeoverflow.chatoverflow.api.io.parameter.ListParameter
 import org.codeoverflow.chatoverflow.registry.Impl
 
-import scala.collection.mutable.ListBuffer
 
 /**
   * A parameter holding a List<String> value.
@@ -19,30 +17,13 @@ class ListParameterImpl extends ListParameter {
   override def getType: Class[List[String]] = classOf[List[String]]
 
   override def serialize(): String = {
-    var out = ""
-    for (part <- value.toArray()) {
-      if (out == "") {
-        out = out + part
-      } else {
-        out = out + "," + part
-      }
-    }
-    out
+    value.asScala.mkString(",")
   }
 
   override def get(): List[String] = value
 
   override def deserialize(value: String): Unit = {
-    var splits = value.split(",");
-    if (splits.length == 1) {
-      set(Collections.singletonList[String](splits(0)))
-    } else {
-      var list: ListBuffer[String] = ListBuffer[String]()
-      for (part <- splits) {
-        list += part
-      }
-      set(mutableSeqAsJavaList[String](list))
-    }
+    set(value.split(",").toSeq.asJava)
   }
 
   override def set(value: List[String]): Unit = this.value = value

src/main/scala/org/codeoverflow/chatoverflow/requirement/parameter/MapParameterImpl.scala

@@ -1,56 +1,32 @@
 package org.codeoverflow.chatoverflow.requirement.parameter
 
-import java.util.{Collections, List}
-
 import org.codeoverflow.chatoverflow.registry.Impl
 import org.codeoverflow.chatoverflow.api.io.parameter.MapParameter
 
 import collection.JavaConverters._
 import java.util.Map
+
 /**
   * A parameter holding a Map<String, String> value.
   */
 @Impl(impl = classOf[MapParameter])
-class MapParameterImpl extends MapParameter{
+class MapParameterImpl extends MapParameter {
   private var value: Map[String, String] = null
 
   override def getType: Class[Map[String, String]] = classOf[Map[String, String]]
 
   override def serialize(): String = {
-    var out = ""
-    value.keySet().forEach(key => {
-      var valueSet = value.get(key)
-      if(out == ""){
-        out = out + "("+key+";"+valueSet+")"
-      }else{
-        out = out + ",("+key+";"+valueSet+")"
-      }
-    })
-    out
+    value.asScala.map({ case (key, value) => s"($key;$value)" }).mkString(",")
   }
 
   override def get(): Map[String, String] = value
 
   override def deserialize(value: String): Unit = {
-    var splits = value.split(",");
-    if (splits.length == 1) {
-      var obj = splits(0)
-      obj = obj.replaceAll("\\(" ,"").replaceAll("\\)","").trim
-      splits = obj.split(";")
-      if(splits.length == 2){
-        set(Collections.singletonMap[String, String](splits(0), splits(1)))
-      }
-    } else {
-      var map = scala.collection.mutable.Map[String, String]()
-      for (part <- splits) {
-        var obj: String = part.replaceAll("\\(" ,"").replaceAll("\\)","").trim
-        var parts = obj.split(";")
-        if(parts.length == 2){
-          map += (parts(0) -> parts(1))
-        }
-      }
-      if(map.nonEmpty) set(mutableMapAsJavaMap[String, String](map))
-    }
+    val kvpair = "\\((.+);(.+)\\)".r
+    val konly = "\\((.+);\\)".r
+    set(value.split(",")
+      .map({ case kvpair(k, v) => (k -> v); case konly(k) => (k -> ""); case _ => ("" -> "") })
+      .toMap.asJava)
   }
 
   override def set(value: Map[String, String]): Unit = this.value = value