Only start plugins if all dependencies are ready

Author: hlxid

src/main/scala/org/codeoverflow/chatoverflow/instance/PluginInstance.scala

@@ -99,6 +99,11 @@ class PluginInstance(val instanceName: String, pluginType: PluginType) extends W
 
         } else {
 
+          if (!areDependenciesAvailable) {
+            logger error "Dependencies have either failed to resolve and fetch or aren't done yet."
+            return false
+          }
+
           // This is set to false if any connector (aka input/output) is not ready.
           var allConnectorsReady = true
 
@@ -224,6 +229,16 @@ class PluginInstance(val instanceName: String, pluginType: PluginType) extends W
     }
   }
 
+  /**
+   * Returns whether all dependencies are resolved and fetch which is required for the plugin to start.
+   *
+   * @return true if all dependencies are available, true if not done of failed.
+   */
+  def areDependenciesAvailable: Boolean = {
+    val opt = pluginType.getDependencyFuture.value
+    opt.isDefined && opt.get.isSuccess
+  }
+
   /**
     * Returns if the plugin is currently executed (the thread is running)
     *

src/main/scala/org/codeoverflow/chatoverflow/ui/web/rest/plugin/PluginInstanceController.scala

@@ -46,6 +46,9 @@ class PluginInstanceController(implicit val swagger: Swagger) extends JsonServle
             } else if (!pluginInstance.get.getRequirements.getAccess.isComplete) {
               ResultMessage(success = false, "Not all required requirements have been set.")
 
+            } else if (!pluginInstance.get.areDependenciesAvailable) {
+              ResultMessage(success = false, "Dependencies have either failed to resolve and fetch or aren't done yet. Check logs for further information.")
+
             } else if (!pluginInstance.get.start()) {
               ResultMessage(success = false, "Unable to start plugin.")